Address PR feedback:

- Use apporximate latitude/longitude properties instead of calling private methods
- Round coordinates to 6 decimal places in serializer
- Update field names from true_latitude/longitude to latitude/longitude

Author: alisx255

backend/market/migrations/0005_sublet_true_latitude_sublet_true_longitude.py

@@ -12,14 +12,14 @@ class Migration(migrations.Migration):
     operations = [
         migrations.AddField(
             model_name="sublet",
-            name="true_latitude",
+            name="latitude",
             field=models.DecimalField(
                 blank=True, decimal_places=6, max_digits=9, null=True
             ),
         ),
         migrations.AddField(
             model_name="sublet",
-            name="true_longitude",
+            name="longitude",
             field=models.DecimalField(
                 blank=True, decimal_places=6, max_digits=9, null=True
             ),

backend/market/models.py

@@ -3,7 +3,9 @@
 from django.core.validators import MinValueValidator
 from django.db import models
 from phonenumber_field.modelfields import PhoneNumberField
-
+import hashlib
+import math
+from decimal import Decimal
 
 class User(AbstractUser):
     """
@@ -130,9 +132,9 @@ class Sublet(Listing):
     start_date = models.DateField()
     end_date = models.DateField()
 
-    true_latitude = models.DecimalField(
+    latitude = models.DecimalField(
         max_digits=9, decimal_places=6, null=True, blank=True)
-    true_longitude = models.DecimalField(
+    longitude = models.DecimalField(
         max_digits=9, decimal_places=6, null=True, blank=True)
 
 
@@ -141,16 +143,14 @@ def clean(self):
         if self.start_date and self.end_date and self.start_date >= self.end_date:
             raise ValidationError({"end_date": "End date must be after start date"})
 
-    def _calculate_fake_location(self, true_latitude, true_longitude):
-        import hashlib
-        import math
-        from decimal import Decimal
+    def _calculate_approximate_location(self, latitude, longitude):
+        
 
-        if true_latitude is None or true_longitude is None:
+        if latitude is None or longitude is None:
             return None, None
 
-        lat_str = f"{float(true_latitude):.6f}"
-        lon_str = f"{float(true_longitude):.6f}"
+        lat_str = f"{float(latitude):.6f}"
+        lon_str = f"{float(longitude):.6f}"
         seed = hashlib.md5(f"{lat_str}{lon_str}".encode()).hexdigest()
 
         offset_factor = int(seed[:8], 16) / 0xFFFFFFFF
@@ -161,24 +161,24 @@ def _calculate_fake_location(self, true_latitude, true_longitude):
         lat_offset = offset_distance * math.sin(angle)
         lon_offset = offset_distance * math.cos(angle)
 
-        approx_lat = Decimal(str(float(true_latitude) + lat_offset))
-        approx_lon = Decimal(str(float(true_longitude) + lon_offset))
+        approx_lat = Decimal(str(float(latitude) + lat_offset))
+        approx_lon = Decimal(str(float(longitude) + lon_offset))
         return approx_lat, approx_lon
 
     @property
-    def fake_latitude(self):
-        if self.true_latitude and self.true_longitude:
-            fake_lat, _ = self._calculate_fake_location(
-                self.true_latitude, self.true_longitude)
-            return fake_lat
+    def approximate_latitude(self):
+        if self.latitude and self.longitude:
+            approximate_latitude, _ = self._calculate_approximate_location(
+                self.latitude, self.longitude)
+            return approximate_latitude
         return None
 
     @property
-    def fake_longitude(self):
-        if self.true_latitude and self.true_longitude:
-            _, fake_lon = self._calculate_fake_location(
-                self.true_latitude, self.true_longitude)
-            return fake_lon
+    def approximate_longitude(self):
+        if self.latitude and self.longitude:
+            _, approximate_lon = self._calculate_approximate_location(
+                self.latitude, self.longitude)
+            return approximate_lon
         return None
 
     def save(self, *args, **kwargs):

backend/market/serializers.py

@@ -14,6 +14,7 @@
 
 from market.mixins import ListingTypeMixin
 from market.models import Category, Item, Listing, ListingImage, Offer, Sublet, Tag
+from decimal import ROUND_DOWN, Decimal
 
 
 User = get_user_model()
@@ -107,21 +108,15 @@ class Meta:
             "latitude", "longitude"]
 
     def get_latitude(self, obj):
-        if obj.true_latitude and obj.true_longitude:
-            fake_lat, _ = obj._calculate_fake_location(
-                obj.true_latitude, obj.true_longitude)
-            return float(fake_lat) if fake_lat else None
+        if obj.approximate_latitude:
+            return round(float(obj.approximate_latitude), 6)
         return None
 
     def get_longitude(self, obj):
-        if obj.true_latitude and obj.true_longitude:
-            _, fake_lon = obj._calculate_fake_location(
-                obj.true_latitude, obj.true_longitude)
-            return float(fake_lon) if fake_lon else None
+        if obj.approximate_longitude:
+            return round(float(obj.approximate_longitude), 6)
         return None
 
-
-
 # Unified serializer for all listing types (Items and Sublets); used for CRUD operations
 class ListingSerializer(ListingTypeMixin, ModelSerializer):
     LISTING_TYPE_CONFIG = {
@@ -274,27 +269,27 @@ def _create_item(self, validated_data, additional_data):
         return item
 
     def _create_sublet(self, validated_data, additional_data):
-        from decimal import ROUND_DOWN, Decimal
         tags = validated_data.pop("tags", None)
 
         latitude = additional_data.get("latitude")
         longitude = additional_data.get("longitude")
 
+        
         if latitude is not None:
             latitude = Decimal(str(latitude)).quantize(
-                Decimal("1.000000"), rounding=ROUND_DOWN)
+                Decimal("0.000001"), rounding=ROUND_DOWN)
         if longitude is not None:
             longitude = Decimal(str(longitude)).quantize(
-                Decimal("1.000000"), rounding=ROUND_DOWN)
-
+                Decimal("0.000001"), rounding=ROUND_DOWN)
+        
         sublet = Sublet.objects.create(
             street_address=additional_data.get("street_address"),
             beds=additional_data.get("beds"),
             baths=additional_data.get("baths"),
             start_date=additional_data.get("start_date"),
             end_date=additional_data.get("end_date"),
-            true_latitude=latitude,
-            true_longitude=longitude,
+            latitude=latitude,
+            longitude=longitude,
             **validated_data,
         )
 
@@ -352,9 +347,15 @@ def _update_sublet(self, instance, additional_data):
             if field in additional_data:
                 setattr(sublet, field, additional_data[field])
         if "latitude" in additional_data:
-            sublet.true_latitude = additional_data["latitude"]
+            latitude = Decimal(str(additional_data["latitude"])).quantize(
+                Decimal("0.000001"), rounding=ROUND_DOWN
+            )
+            sublet.latitude = latitude
         if "longitude" in additional_data:
-            sublet.true_longitude = additional_data["longitude"]
+            longitude = Decimal(str(additional_data["longitude"])).quantize(
+                Decimal("0.000001"), rounding=ROUND_DOWN
+            )
+            sublet.longitude = longitude
         sublet.full_clean()
         sublet.save()