Fixing type check errors

Author: LautaroJBeck

backend/market/management/commands/seed_offers.py

@@ -18,7 +18,7 @@ def add_arguments(self, parser):
             "--listing-id",
             type=int,
             default=None,
-            help="Add offers to an existing listing by ID instead of creating a new one",
+            help="Add offers to an existing listing by ID",
         )
 
     def handle(self, *args, **options):
@@ -48,16 +48,24 @@ def handle(self, *args, **options):
         bob.set_password("testpassword123")
         bob.save()
 
-        self.stdout.write(self.style.SUCCESS("Buyers ready: Alice Johnson, Bob Williams"))
+        self.stdout.write(
+            self.style.SUCCESS("Buyers ready: Alice Johnson, Bob Williams")
+        )
 
         listing_id = options["listing_id"]
         if listing_id:
             try:
                 listing = Listing.objects.get(pk=listing_id)
             except Listing.DoesNotExist:
-                self.stdout.write(self.style.ERROR(f"Listing with id={listing_id} not found"))
+                self.stdout.write(
+                    self.style.ERROR(f"Listing with id={listing_id} not found")
+                )
                 return
-            self.stdout.write(self.style.SUCCESS(f"Using existing listing: {listing.title} (id={listing.id})"))
+            self.stdout.write(
+                self.style.SUCCESS(
+                    f"Using existing listing: {listing.title} (id={listing.id})"
+                )
+            )
         else:
             seller, _ = User.objects.get_or_create(
                 username="lautaro",
@@ -69,7 +77,9 @@ def handle(self, *args, **options):
             )
             seller.set_password("testpassword123")
             seller.save()
-            self.stdout.write(self.style.SUCCESS(f"Seller ready: {seller.get_full_name()}"))
+            self.stdout.write(
+                self.style.SUCCESS(f"Seller ready: {seller.get_full_name()}")
+            )
 
             category, _ = Category.objects.get_or_create(name="Furniture")
             listing = Item.objects.create(
@@ -105,5 +115,11 @@ def handle(self, *args, **options):
         new_count = sum([created_alice, created_bob])
         skipped = 2 - new_count
 
-        self.stdout.write(self.style.SUCCESS(f"Created {new_count} offers, skipped {skipped} (already existed)"))
-        self.stdout.write(self.style.SUCCESS(f"\nDone! Offers added to listing id={listing.id}"))
+        self.stdout.write(
+            self.style.SUCCESS(
+                f"Created {new_count} offers, skipped {skipped} (already existed)"
+            )
+        )
+        self.stdout.write(
+            self.style.SUCCESS(f"\nDone! Offers added to listing id={listing.id}")
+        )

backend/market/serializers.py

@@ -82,6 +82,7 @@ class OfferDetailsSerializer(ModelSerializer):
     Allows the offer owner to edit the offer's offered_price and message.
     Status is intentionally read-only (managed by the listing owner).
     """
+
     class Meta:
         model = Offer
         fields = ["id", "offered_price", "message", "status"]

backend/market/urls.py

@@ -13,8 +13,8 @@
     UserFavorites,
     change_offer_details,
     change_offer_status,
-    get_my_offer_for_listing,
     get_current_user,
+    get_my_offer_for_listing,
     get_phone_status,
     send_verification_code,
     verify_phone_code,

backend/market/views.py

@@ -21,18 +21,18 @@
 from market.permissions import (
     IsSuperUser,
     ListingImageOwnerPermission,
-    ListingOwnerPermission,
     ListingOwnerOffersPermission,
+    ListingOwnerPermission,
 )
 from market.serializers import (
     ListingImageSerializer,
     ListingImageURLSerializer,
     ListingSerializer,
     ListingSerializerList,
     ListingSerializerPublic,
+    OfferDetailsSerializer,
     OfferSerializer,
     OfferStatusSerializer,
-    OfferDetailsSerializer,
     TagSerializer,
     UserSerializer,
 )

frontend/components/listings/detail/EditListing.tsx

@@ -12,7 +12,14 @@ import { Input } from "@/components/ui/input";
 import { updateListing } from "@/lib/actions";
 import { BEDS_OPTIONS, BATHS_OPTIONS, CATEGORY_OPTIONS, CONDITION_OPTIONS } from "@/lib/constants";
 import { parsePriceString } from "@/lib/utils";
-import type { Item, Sublet, UpdateItemPayload, UpdateSubletPayload } from "@/lib/types";
+import type {
+  Item,
+  ItemCategory,
+  ItemCondition,
+  Sublet,
+  UpdateItemPayload,
+  UpdateSubletPayload,
+} from "@/lib/types";
 import {
   editItemSchema,
   editSubletSchema,
@@ -34,8 +41,11 @@ interface Props {
   onOpenChange: (open: boolean) => void;
 }
 
-const resolveConditionValue = (condition: string) =>
-  CONDITION_OPTIONS.find((option) => option.label === condition)?.value ?? condition;
+const resolveConditionValue = (condition: string | undefined): ItemCondition | undefined => {
+  if (condition === undefined) return undefined;
+  const match = CONDITION_OPTIONS.find((option) => option.label === condition);
+  return match ? match.value : (condition as ItemCondition);
+};
 
 const EditItemContent = ({
   listing,
@@ -109,7 +119,7 @@ const EditItemContent = ({
           <FormSelect
             label="Product Category"
             value={field.value}
-            onChange={field.onChange}
+            onChange={(val) => field.onChange(val as ItemCategory)}
             options={CATEGORY_OPTIONS}
             placeholder="Select Category"
             error={errors.category?.message}
@@ -124,7 +134,7 @@ const EditItemContent = ({
           <FormSelect
             label="Condition"
             value={field.value}
-            onChange={field.onChange}
+            onChange={(val) => field.onChange(val as ItemCondition)}
             options={CONDITION_OPTIONS}
             placeholder="Select Condition"
             error={errors.condition?.message}

frontend/lib/actions.ts

@@ -97,7 +97,10 @@ async function serverFetch<T>(endpoint: string, options: RequestInit = {}): Prom
 
     throw new APIError(errorMessage, response.status);
   }
-  return response.json();
+  // Some DELETE endpoints return `204 No Content`; attempting `response.json()` would throw.
+  if (response.status === 204) return null as unknown as T;
+
+  return response.json().catch(() => null as unknown as T);
 }
 
 // ------------------------------------------------------------
@@ -207,8 +210,8 @@ export async function createOffer({
   listingId: number;
   offeredPrice: number;
   message?: string;
-}) {
-  return await serverFetch(`/market/listings/${listingId}/offers/`, {
+}): Promise<Offer> {
+  return await serverFetch<Offer>(`/market/listings/${listingId}/offers/`, {
     method: "POST",
     body: JSON.stringify({
       offered_price: offeredPrice,