Merge pull request #139 from pennlabs/registrar-no-prof

Fix registrar details when no instructor provided

Author: dlakata

PennMobile/src/main/java/com/pennapps/labs/pennmobile/RegistrarFragment.java

@@ -129,7 +129,11 @@ protected Boolean doInBackground(Void... voids) {
                 activityText = course.activity;
                 locationText = courseCodeText + " - " + course.meetings.get(0).building_code + " " + course.meetings.get(0).room_number;
                 courseTitleText = course.course_title;
-                instructorsText = course.instructors.get(0).name;
+                try {
+                    instructorsText = course.instructors.get(0).name;
+                } catch (IndexOutOfBoundsException e) {
+                    instructorsText = getString(R.string.professor_missing);
+                }
                 courseDescription = course.course_description;
                 return true;
             } catch (Exception ignored) {
@@ -140,7 +144,7 @@ protected Boolean doInBackground(Void... voids) {
         @Override
         protected void onPostExecute(Boolean valid) {
             if (!valid || courses.size() == 0) {
-                courseCodeTextView.setText(input);
+                courseCodeTextView.setText(courseCodeText);
                 courseTitleTextView.setText(input + " is not currently offered.");
                 return;
             }
@@ -157,6 +161,9 @@ protected void onPostExecute(Boolean valid) {
                 courseActivityTextView.setText(activityText);
                 courseTitleTextView.setText(courseTitleText);
                 instructorTextView.setText(instructorsText);
+                if (instructorsText.equals(getString(R.string.professor_missing))) {
+                    instructorTextView.setTextColor(getResources().getColor(R.color.color_primary_light));
+                }
 
                 if (courseDescription.equals("")) {
                     descriptionTitle.setVisibility(View.GONE);

PennMobile/src/main/java/com/pennapps/labs/pennmobile/adapters/RegistrarAdapter.java

@@ -45,7 +45,7 @@ public View getView(int position, View convertView, ViewGroup parent) {
         try {
             courseInstr.setText(course.instructors.get(0).name);
         } catch (IndexOutOfBoundsException e) {
-            courseInstr.setText("No professor listed");
+            courseInstr.setText(getContext().getString(R.string.professor_missing));
             courseInstr.setTextColor(Color.parseColor("#4a000000"));
         }
         courseTitle.setText(course.course_title);

PennMobile/src/main/res/values/strings.xml

@@ -33,5 +33,6 @@
     <string name="course">Course</string>
     <string name="instructor">Instructor</string>
     <string name="difficulty">Difficulty</string>
+    <string name="professor_missing">No professor listed</string>
 
 </resources>