Skip to content

Commit cd8c466

Browse files
Full Dining rewrite (#250)
* Made some progress in dining api rewrite * Greatly simplified DiningVenue parsing logic by depending completely on custom Codable implementations * Improved handling of .meals property of DiningVenue; it is now a date to meals dict * Implemented hour formatting functions * Reintegrated pods. Beginning work on DiningViewModel * Created DiningDataStore, beginning to replace cache/api logic. * Created new networking functions, hooked them up to DiningAPI * Reimplemented dining settings, removed most menu code * Finished base implementation of dynamic dining screen * Initial implementation of lightweight cacheing layer * Completed cacheing implementation. Fixed dining settings. Finished dynamic loading of Dining. * Removed many old files. * Removed venue assets (3mb), completed Fall 2019 dining rewrite pending feedback * Moved the cache to its own file * Fixes based on josh comments * fixed venue category names * Coding Key change for image url * removed print * Added images and fixed on-first-load behavior * Filtering Houston market * Added closed today label * Added date diffing so venues say when they are next open * Fixed merge conflicts * Made dining status labels lowercase * Fixed dining cell color * Changed date display string, now displays next open time if distance over 1 hour * Changed dining status format
1 parent f92cbb2 commit cd8c466

73 files changed

Lines changed: 866 additions & 1664 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

PennMobile.xcodeproj/project.pbxproj

Lines changed: 136 additions & 188 deletions
Large diffs are not rendered by default.
Binary file not shown.

PennMobile/Assets.xcassets/Dining/1920 Commons.imageset/Contents.json

Lines changed: 0 additions & 21 deletions
This file was deleted.
Binary file not shown.

PennMobile/Assets.xcassets/Dining/1920 Gourmet Grocer.imageset/Contents.json

Lines changed: 0 additions & 21 deletions
This file was deleted.

PennMobile/Assets.xcassets/Dining/1920 Starbucks.imageset/Contents.json

Lines changed: 0 additions & 21 deletions
This file was deleted.
Binary file not shown.

PennMobile/Assets.xcassets/Dining/Accenture Cafe.imageset/Contents.json

Lines changed: 0 additions & 21 deletions
This file was deleted.
Binary file not shown.

PennMobile/Assets.xcassets/Dining/AppIcon.appiconset/Contents.json

Lines changed: 0 additions & 53 deletions
This file was deleted.

0 commit comments

Comments
 (0)