Skip to content

Commit 1383691

Browse files
committed
makes api_wrapper thread only API calls
1 parent f8083ac commit 1383691

3 files changed

Lines changed: 3 additions & 35 deletions

File tree

backend/dining/-- SQLite.sql

Lines changed: 0 additions & 26 deletions
This file was deleted.

backend/dining/api_wrapper.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def get_venues(self):
5959
venues_route = OPEN_DATA_ENDPOINTS["VENUES"]
6060
response = self.request("GET", venues_route)
6161
if response.status_code != 200:
62-
raise APIError("Dining: Error connecting to API")
62+
raise APIError(f"Dining: error connecting to API " + response.text)
6363
venues = response.json()["result_data"]["campuses"]["203"]["cafes"]
6464
for key, value in venues.items():
6565
# Cleaning up json response
@@ -115,8 +115,8 @@ def fetch_menu(self, venue_id, date):
115115
menu_base = OPEN_DATA_ENDPOINTS["MENUS"]
116116
response = worker.request("GET", f"{menu_base}?cafe={venue_id}&date={date}")
117117
if response.status_code != 200:
118-
raise APIError("Dining: Error connecting to API") # MINGHAN WHICH ERRORS SHOULD I BE CATCHING
119-
return venue_id, response.json()
118+
raise APIError(f"Dining: error connecting to API " + response.text)
119+
return venue_id, response.json() # also storing venue_id to later access in fetched_menus list
120120

121121
def load_menu(self, date=timezone.now().date()):
122122
"""

backend/dining/management/commands/load_next_menu.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,7 @@ def handle(self, *args, **kwargs):
2727
"""
2828
Load menu for the next 7 days
2929
"""
30-
start_time = timezone.now()
31-
3230
for i in range(7):
3331
self.load_one_menu(i)
34-
35-
end_time = timezone.now()
36-
elapsed_time = end_time - start_time
37-
self.stdout.write(f"TOTAL menu stuff for today took {elapsed_time} seconds")
3832

3933

0 commit comments

Comments
 (0)