Skip to content

Commit 70e72e0

Browse files
committed
call get_usages one time
1 parent fac021e commit 70e72e0

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

backend/penndata/management/commands/get_fitness_snapshot.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ def handle(self, *args, **kwargs):
5252
all_rooms = FitnessRoom.objects.all()
5353
all_room_names = set(room.name for room in all_rooms)
5454
query = Q()
55-
for room_name, room_usage in get_usages().items():
55+
usages = get_usages()
56+
for room_name, room_usage in usages.items():
5657
query |= Q(room__name=room_name, date=room_usage["last_updated"])
5758
existing_snapshots = FitnessSnapshot.objects.filter(query)
5859
existing_room_date_pairs = set(
@@ -67,7 +68,8 @@ def exists(record):
6768
return False
6869
return True
6970

70-
usage_by_location = filter(exists, get_usages().items())
71+
usage_by_location = filter(exists, usages.items())
72+
usage_by_location_list = list(usage_by_location)
7173
FitnessSnapshot.objects.bulk_create(
7274
[
7375
FitnessSnapshot(
@@ -76,7 +78,7 @@ def exists(record):
7678
count=room_usage["count"],
7779
capacity=room_usage["capacity"],
7880
)
79-
for (room_name, room_usage) in usage_by_location
81+
for (room_name, room_usage) in usage_by_location_list
8082
]
8183
)
8284

0 commit comments

Comments
 (0)