Skip to content

Commit ca973ac

Browse files
committed
Fixed test cases + error return status code
1 parent 0c83c35 commit ca973ac

10 files changed

Lines changed: 766 additions & 854 deletions

backend/market/views.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ def create(self, request, *args, **kwargs):
251251
item_id = int(self.kwargs["item_id"])
252252
queryset = self.get_queryset()
253253
if queryset.filter(id=item_id).exists():
254-
raise exceptions.NotAcceptable("Favorite already exists")
254+
raise exceptions.ValidationError("Favorite already exists")
255255
item = get_object_or_404(Item, id=item_id)
256256
self.get_queryset().add(item)
257257
return Response(status=status.HTTP_201_CREATED)
@@ -289,7 +289,7 @@ def create(self, request, *args, **kwargs):
289289
data = request.data
290290
request.POST._mutable = True
291291
if self.get_queryset().filter(user=self.request.user).exists():
292-
raise exceptions.NotAcceptable("Offer already exists")
292+
raise exceptions.ValidationError("Offer already exists")
293293
data["item"] = int(self.kwargs["item_id"])
294294
data["user"] = self.request.user.id
295295
serializer = self.get_serializer(data=request.data)
@@ -299,7 +299,10 @@ def create(self, request, *args, **kwargs):
299299

300300
def destroy(self, request, *args, **kwargs):
301301
queryset = self.get_queryset()
302-
filter = {"user": self.request.user, "item": int(self.kwargs["item_id"])}
302+
filter = {
303+
"user": self.request.user,
304+
"item": int(self.kwargs["item_id"]),
305+
}
303306
obj = get_object_or_404(queryset, **filter)
304307
self.check_object_permissions(self.request, obj)
305308
self.perform_destroy(obj)

backend/tests/market/mock_items.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"price": 20.0,
99
"negotiable": true,
1010
"created_at": "2024-11-13T20:14:34.604238-05:00",
11-
"expires_at": "2025-12-12T00:00:00-05:00"
11+
"expires_at": "3000-12-12T00:00:00-05:00"
1212
},
1313
{
1414
"tags": ["New"],
@@ -19,7 +19,7 @@
1919
"price": 5.0,
2020
"negotiable": false,
2121
"created_at": "2024-11-13T20:14:34.604238-05:00",
22-
"expires_at": "2025-10-12T00:00:00-05:00"
22+
"expires_at": "3000-10-12T00:00:00-05:00"
2323
},
2424
{
2525
"tags": ["Laptop", "New"],
@@ -30,7 +30,7 @@
3030
"price": 2000.0,
3131
"negotiable": true,
3232
"created_at": "2024-11-13T20:14:34.604238-05:00",
33-
"expires_at": "2025-08-12T00:00:00-05:00"
33+
"expires_at": "3000-08-12T00:00:00-05:00"
3434
},
3535
{
3636
"tags": ["Couch"],
@@ -41,6 +41,6 @@
4141
"price": 400.0,
4242
"negotiable": true,
4343
"created_at": "2024-11-13T20:14:34.604238-05:00",
44-
"expires_at": "2025-12-12T00:00:00-05:00"
44+
"expires_at": "3000-12-12T00:00:00-05:00"
4545
}
4646
]

backend/tests/market/mock_sublets.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@
1111
"price": 1350.0,
1212
"negotiable": false,
1313
"created_at": "2024-11-13T20:14:34.604238-05:00",
14-
"expires_at": "2025-12-12T00:00:00-05:00"
14+
"expires_at": "3000-12-12T00:00:00-05:00"
1515
},
1616
"address": "Cira Green, Philadelphia, PA",
1717
"beds": 3.0,
1818
"baths": 1.0,
1919
"start_date": "2024-01-01T00:00:00-05:00",
20-
"end_date": "2025-05-31T00:00:00-04:00"
20+
"end_date": "3000-05-31T00:00:00-04:00"
2121
},
2222
{
2323
"item": {
@@ -31,12 +31,12 @@
3131
"price": 1350.0,
3232
"negotiable": false,
3333
"created_at": "2024-11-13T20:14:34.604238-05:00",
34-
"expires_at": "2025-12-12T00:00:00-05:00"
34+
"expires_at": "3000-12-12T00:00:00-05:00"
3535
},
3636
"address": "3901 Locust Walk, Philadelphia, PA",
3737
"beds": 4.0,
3838
"baths": 1.0,
3939
"start_date": "2024-01-01T00:00:00-05:00",
40-
"end_date": "2025-05-31T00:00:00-04:00"
40+
"end_date": "3000-05-31T00:00:00-04:00"
4141
}
4242
]

backend/tests/market/self_user_items.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88
"price": 20.0,
99
"negotiable": true,
1010
"created_at": "2024-11-13T20:14:34.604238-05:00",
11-
"expires_at": "2025-12-12T00:00:00-05:00"
11+
"expires_at": "3000-12-12T00:00:00-05:00"
1212
}
1313
]

backend/tests/market/self_user_sublets.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
"price": 1350.0,
1212
"negotiable": false,
1313
"created_at": "2024-11-13T20:14:34.604238-05:00",
14-
"expires_at": "2025-12-12T00:00:00-05:00"
14+
"expires_at": "3000-12-12T00:00:00-05:00"
1515
},
1616
"address": "Cira Green, Philadelphia, PA",
1717
"beds": 3.0,
1818
"baths": 1.0,
1919
"start_date": "2024-01-01T00:00:00-05:00",
20-
"end_date": "2025-05-31T00:00:00-04:00"
20+
"end_date": "3000-05-31T00:00:00-04:00"
2121
}
2222
]

0 commit comments

Comments
 (0)