Skip to content

🐛 Fix problem with default shadows in plugins #6114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

Alotor
Copy link
Member

@Alotor Alotor commented Mar 19, 2025

Related Ticket

https://tree.taiga.io/project/penpot/issue/10263

Summary

Default value for shadows is null when should be an empty array.

Steps to reproduce

  • Create board
  • Access the shape's shadows via penpot.selection.shapes[id].shadows

Checklist

  • Choose the correct target branch; use develop by default.
  • Provide a brief summary of the changes introduced.
  • Add a detailed explanation of how to reproduce the issue and/or verify the fix, if applicable.
  • Include screenshots or videos, if applicable.
  • Add or modify existing integration tests in case of bugs or new features, if applicable.
  • Check CI passes successfully.
  • Update the CHANGES.md file, referencing the related GitHub issue, if applicable.

@Alotor Alotor linked an issue Mar 19, 2025 that may be closed by this pull request
@AzazelN28 AzazelN28 self-assigned this Mar 19, 2025
@AzazelN28 AzazelN28 merged commit d01eccf into staging Mar 19, 2025
9 checks passed
@AzazelN28 AzazelN28 deleted the alotor-fix-plugins-shapows branch March 19, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Shape.shadows is potentially null
2 participants