Skip to content

White space between segments #2

Description

@charlotteburkirts

The width attribute of a segment is calculated using the first and last index of the segment: at line 106 of frontend/src/components/timeline.js

.attr("width", s.end * xStep - s.start * xStep)

As these indexes are inclusive the width is one step too small. As an example if a face appear on frame 1, 2, and 3 the segment will have a width corresponding of two steps while the face actually appears on 3 frames (three steps).

We propose to change that line to:
.attr("width", (s.end + 1) * xStep - s.start * xStep)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions