Skip to content

🔗 integration test coverage for grpc-web compatibility #3704

Open
@cratelyn

Description

@cratelyn

it is an important requirement of pd that we have maintain compatibility with gRPC-web clients. the https://github.com/penumbra-zone/web project depends upon connect-es to communicate with nodes via the gRPC-web protocol.

to address #3627, we tested that #3652 maintained compatibility by spinning up a live validator and connecting to it via the web wallet. this is a time-consuming process that we can't perform on every PR, so we nonetheless observed a regression after landing other seemingly innocuous changes to pd's router. (see #3697, #3679)

we should introduce some integration test coverage that demonstrates that a gRPC-web client can properly communicate with a fullnode.

i would prefer if the solution to this does not entail depending on the web repository as a submodule. perhaps we could spin up a test client that also uses the same connect-es library, to show that transport works properly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-CI/CDRelates to continuous integration & deployment of PenumbraA-nodeArea: System design and implementation for node software_P-lowPriority: low

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions