Skip to content

FMD Sliding Window Algorithm has an edge case bug #4705

Open
@cronokirby

Description

@cronokirby

Precision::new(1u8).expect("1 is a valid precision")

In the case that there have been an estimated 0 clues over the past window, the targeted precision should be 0 (detect all clues) and not 1 (detect 50% of all clues).

One way to solve this in a non-consensus-breaking way is to add a flag to the algorithm in protobuf which will enable the fix here.

Also, this being wrong shouldn't cause clients to break, only that they use a sub-optimal precision for when transactions start up again.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: a bug

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions