Skip to content

bug: minifront version in footer is a broken link #2057

Open
@conorsch

Description

@conorsch

Describe the bug
When I run the bundled frontend within pd, I see a footer with version and date information:

Image

That's rad. However, the linked git commit is a broken URL.

Expected behavior
I expect that I can click on the abbreviated hash to be taken to a specific commit in the web repo. The specific URL I was shown is http://localhost:8080/app/[email protected]:penumbra-zone/web/commits/ba65187648cbc963c41ea4297e91676720026acd.

Additional context
The problem is two-fold:

  1. the commit sha is interpolated based on the git remote settings, so in my local build i saw [email protected] rather than https://github.com/
  2. the URL is built as a relative path, meaning the pd endpoint is prefixed to it, as http://localhost:8080/app/ in the example above.

Encountered this while working on penumbra-zone/penumbra#5089.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions