Open
Description
Describe the bug
When I run the bundled frontend within pd
, I see a footer with version and date information:
That's rad. However, the linked git commit is a broken URL.
Expected behavior
I expect that I can click on the abbreviated hash to be taken to a specific commit in the web repo. The specific URL I was shown is http://localhost:8080/app/[email protected]:penumbra-zone/web/commits/ba65187648cbc963c41ea4297e91676720026acd
.
Additional context
The problem is two-fold:
- the commit sha is interpolated based on the
git remote
settings, so in my local build i saw[email protected]
rather thanhttps://github.com/
- the URL is built as a relative path, meaning the pd endpoint is prefixed to it, as
http://localhost:8080/app/
in the example above.
Encountered this while working on penumbra-zone/penumbra#5089.