Merge pull request #221 from novafloss/transaction-atomic

Atomic transactions

Author: mgu

CHANGELOG.rst

@@ -5,7 +5,7 @@ ChangeLog
 master (unreleased)
 ===================
 
-- Nothing changed yet.
+- Use an atomic transaction in FormidableSerialize.save() (#220)
 
 Release 0.9.0 (2017-04-11)
 ==========================

demo/tests/test_end_point.py

@@ -4,7 +4,9 @@
 import copy
 from functools import reduce
 
-from django.test import TestCase
+from django.db import connection
+from django.test import TestCase, TransactionTestCase
+from django.test.utils import CaptureQueriesContext
 import django_perf_rec
 
 from formidable import constants
@@ -859,6 +861,20 @@ def test_create_sepa(self):
         self.assertTrue(qs.exists())
 
 
+class CreateSerializerTransactionTestCase(TransactionTestCase):
+
+    def test_unique_transaction(self):
+        data = copy.deepcopy(CreateSerializerTestCase.data)
+        data['fields'] = CreateSerializerTestCase.fields_with_items
+        serializer = FormidableSerializer(data=data)
+        self.assertTrue(serializer.is_valid(), serializer.errors)
+        with CaptureQueriesContext(connection) as capture:
+            serializer.save()
+        begin_count = sum(1 for query in capture.captured_queries
+                          if query['sql'] == 'BEGIN')
+        self.assertEqual(begin_count, 1)
+
+
 class UpdateFormTestCase(TestCase):
 
     data = {

formidable/serializers/forms.py

@@ -3,6 +3,7 @@
 from __future__ import unicode_literals
 
 from django.core.exceptions import ValidationError
+from django.db import transaction
 
 from formidable.models import Formidable
 from formidable.serializers import fields
@@ -59,6 +60,10 @@ def check_presets_cohesion(self, data):
                     )
         return data
 
+    def save(self, *args, **kwargs):
+        with transaction.atomic():
+            return super(FormidableSerializer, self).save(*args, **kwargs)
+
 
 class ContextFormSerializer(serializers.ModelSerializer):