Merge pull request #392 from peopledoc/allow-empty-defaults-value-hotfix

Allow empty defaults value hotfix

Author: brunobord

CHANGELOG.rst

@@ -2,6 +2,11 @@
 ChangeLog
 =========
 
+Release 4.0.2 (unreleased)
+==========================
+
+- HOTFIX: Allow empty values for ``defaults`` properties (#391).
+
 Release 4.0.1 (2020-01-21)
 ==========================
 

demo/tests/serializers/test_formidable_serializer.py

@@ -103,5 +103,39 @@ def test_context_in_field_serializer(self):
         # remove mock and revert serializer
         self.field_register[self.custom_type_id] = backup_serializer
 
+    def test_empty_string_defaults(self):
+        schema = {
+            "label": "test",
+            "description": "test",
+            "fields": [
+                {
+                    "slug": "custom-type-id",
+                    "label": "Custom field",
+                    "placeholder": None,
+                    "description": None,
+                    "defaults": [],
+                    "multiple": False,
+                    "values": [],
+                    "required": False,
+                    "disabled": False,
+                    "isVisible": True,
+                    "type_id": "text",
+                    "validations": [],
+                    "accesses": [
+                        {
+                            "id": "field-access868",
+                            "level": "EDITABLE",
+                            "access_id": "padawan"
+                        }
+                    ]
+                }
+            ]
+        }
+        # to make sure we know the use-case we want to test.
+        schema['fields'][0]['defaults'] = [""]
+        serializer = FormidableSerializer(data=schema)
+        assert serializer.is_valid(), serializer.errors
+
     def tearDown(self):
+        super().tearDown()
         self.field_register.pop(self.custom_type_id)

formidable/migrations/0010_auto_20200213_1010.py

@@ -0,0 +1,18 @@
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('formidable', '0009_field_parameters'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='default',
+            name='value',
+            field=models.CharField(blank=True, max_length=256),
+        ),
+    ]

formidable/models.py

@@ -103,7 +103,7 @@ def __str__(self):
 @python_2_unicode_compatible
 class Default(models.Model):
 
-    value = models.CharField(max_length=256)
+    value = models.CharField(max_length=256, blank=True)
     field = models.ForeignKey(
         Field, related_name='defaults', on_delete=models.CASCADE
     )