Skip to content

Commit 5665662

Browse files
authored
Merge pull request #104 from novafloss/103_fix_disabled_attribute
Does not set the disabled attribute in widget
2 parents db55bd8 + 3a403e8 commit 5665662

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

demo/tests/test_forms.py

+9
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,15 @@ def test_readonly_field(self):
226226
self.assertEquals(field.required, False)
227227
self.assertEquals(field.widget.attrs['disabled'], True)
228228

229+
def test_no_disabled_attr(self):
230+
self.text_field.accesses.create(access_id=u'human', level=EDITABLE)
231+
form_class = self.form.get_django_form_class(role=u'human')
232+
form = form_class()
233+
self.assertIn('text-input', form.fields)
234+
field = form.fields['text-input']
235+
self.assertEquals(field.required, False)
236+
self.assertNotIn('disabled', field.widget.attrs)
237+
229238
def test_hidden_field(self):
230239
self.text_field.accesses.create(access_id=u'human', level=HIDDEN)
231240
form_class = self.form.get_django_form_class(role=u'human')

formidable/forms/field_builder.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,12 @@ def get_widget_kwargs(self):
5757
return {'attrs': self.get_widget_attrs()}
5858

5959
def get_widget_attrs(self):
60-
return {'disabled': self.get_disabled()}
60+
attrs = {}
61+
62+
if self.get_disabled():
63+
attrs['disabled'] = True
64+
65+
return attrs
6166

6267
def get_disabled(self):
6368
if self.access:

0 commit comments

Comments
 (0)