Merge pull request #281 from novafloss/enlarge-formidable-item-value-size

Enlarge formidable item value size

Author: brunobord

CHANGELOG.rst

@@ -11,6 +11,7 @@ master (unreleased)
 - Add configuration for py.test
 - Reactivate accidentally skipped ``test_validations.py`` tests
 - Add JSON migrations
+- ``FormidableItem.value`` field size now has no limit (``TextField``)
 
 Release 1.0.2 (2017-10-10)
 ==========================

demo/tests/test_models.py

@@ -28,14 +28,25 @@ def setUp(self):
         super(FieldItemTestCase, self).setUp()
         self.formidable = FormTest.to_formidable(label='label')
 
-    def test_field_size(self):
+    def test_label_field_size(self):
         field = self.formidable.fields.get(slug='dropdown')
         field.items.create(
             value='hello',
             label="hello" * 800,
             order=42,
         )
 
+    def test_value_field_size(self):
+        field = self.formidable.fields.get(slug='dropdown')
+        my_field = field.items.create(
+            value='hello' * 800,
+            label="hello" * 800,
+            order=42,
+        )
+        my_field = field.items.get(pk=my_field.pk)
+        self.assertEqual(my_field.value, 'hello' * 800)
+        self.assertEqual(my_field.label, 'hello' * 800)
+
 
 class UnicodeTestCase(TestCase):
 

formidable/migrations/0008_formidable_item_value_field_size.py

@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('formidable', '0007_drop_preset_tables'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='item',
+            name='value',
+            field=models.TextField(),
+        ),
+    ]

formidable/models.py

@@ -109,7 +109,7 @@ def __str__(self):
 @python_2_unicode_compatible
 class Item(models.Model):
     field = models.ForeignKey(Field, related_name='items')
-    value = models.CharField(max_length=256)
+    value = models.TextField()
     label = models.TextField()
     order = models.IntegerField()
     help_text = models.TextField(blank=True, null=True)