Merge pull request #9 from peopledoc/fix/exit-status

Make jarvis POSIX compliant by returning an exit status

Author: Nicolas Sterchele

cmd/root.go

@@ -12,6 +12,7 @@ import (
 )
 
 const SilenceUsageOnError = true
+const SilenceErrors = true
 
 var (
 	configFile   string
@@ -20,9 +21,10 @@ var (
 	isDebug      bool
 
 	rootCmd = &cobra.Command{
-		Use:          "jarvis",
-		SilenceUsage: SilenceUsageOnError,
-		Short:        "jarvis is our automation CLI",
+		Use:           "jarvis",
+		SilenceUsage:  SilenceUsageOnError,
+		SilenceErrors: SilenceErrors,
+		Short:         "jarvis is our automation CLI",
 		Long: `jarvis is the main command, used to facilitate SRE's life.
 		
 jarvis is smart, jarvis is beautiful,

internal/pkg/command/runner.go

@@ -35,7 +35,7 @@ func (r Runner) Run(command string, params ...string) error {
 	err := cmd.Start()
 
 	if err != nil {
-		return fmt.Errorf("command: failed to start command:%v, err:%v", command, err)
+		return fmt.Errorf("command: failed to start %v, err:%v", command, err)
 	}
 
 	//To synchronize before calling Wait on cmd
@@ -59,7 +59,7 @@ func (r Runner) Run(command string, params ...string) error {
 	err = cmd.Wait()
 
 	if err != nil {
-		return fmt.Errorf("command: failed to run command:%v, err:%v", command, err)
+		return fmt.Errorf("command: failed to run %v, err:%v", command, err)
 	}
 	if errStdout != nil || errStderr != nil {
 		return fmt.Errorf("command: failed to capture stdout or stderr")

main.go

@@ -1,9 +1,14 @@
 package main
 
 import (
+	"fmt"
 	"jarvis/cmd"
+	"os"
 )
 
 func main() {
-	cmd.Execute()
+	if err := cmd.Execute(); err != nil {
+		fmt.Fprintf(os.Stderr, "%v\n", err)
+		os.Exit(1)
+	}
 }