Serve the site's figures from the site

They were linked from raw.githubusercontent.com, so every figure arrived after
the page and from a host the site is not published on. Pages now copies
docs/assets into the artifact.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: peopleworks

.github/workflows/pages.yml

@@ -5,6 +5,7 @@ on:
     branches: [main]
     paths:
       - 'site/**'
+      - 'docs/assets/**'
       - '.github/workflows/pages.yml'
   workflow_dispatch:
 
@@ -33,11 +34,18 @@ jobs:
       - name: Configure Pages
         uses: actions/configure-pages@v5
 
-      # The site is a single self-contained HTML file: no build step, no dependencies, nothing
-      # to go out of date. .nojekyll stops GitHub running Jekyll over it, which would otherwise
-      # drop any file or directory beginning with an underscore.
+      # The page itself is one hand-written HTML file: no build step, no dependencies, nothing to
+      # go out of date. .nojekyll stops GitHub running Jekyll over it, which would otherwise drop
+      # any file or directory beginning with an underscore.
+      #
+      # The figures are copied in rather than linked from raw.githubusercontent.com. Served from
+      # the same origin they arrive with the page instead of after it, and the site stops
+      # depending on a host that is not the one it is published on.
       - name: Prepare artifact
-        run: touch site/.nojekyll
+        run: |
+          touch site/.nojekyll
+          mkdir -p site/assets
+          cp docs/assets/* site/assets/
 
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v3

site/index.html

@@ -889,7 +889,7 @@ <h3>Migrations that ran once</h3>
 
     <figure class="figure">
       <div class="fig-frame">
-        <img src="https://raw.githubusercontent.com/peopleworks/XAFLogicExplainer/main/docs/assets/explainer-editors.png"
+        <img src="assets/explainer-editors.png"
              alt="The custom editors section: a barcode scanner property editor, what it renders, the alias XAF matches on, its base type, and the JavaScript file it depends on — followed by a table of built-in editors reconfigured at run time by a controller."
              loading="lazy" style="display:block;width:100%;height:auto">
       </div>
@@ -901,7 +901,7 @@ <h3>Migrations that ran once</h3>
 
     <figure class="figure">
       <div class="fig-frame">
-        <img src="https://raw.githubusercontent.com/peopleworks/XAFLogicExplainer/main/docs/assets/explainer-migrations.png"
+        <img src="assets/explainer-migrations.png"
              alt="The migrations section: two version-gated updater blocks, each with the version it upgrades to, the schema phase it ran in, the condition, the methods it calls and the code itself."
              loading="lazy" style="display:block;width:100%;height:auto">
       </div>
@@ -1052,7 +1052,7 @@ <h2>Most teams have never seen<br>their own domain model.</h2>
 
     <figure class="figure">
       <div class="fig-frame">
-        <img src="https://raw.githubusercontent.com/peopleworks/XAFLogicExplainer/main/docs/assets/domain-map.gif"
+        <img src="assets/domain-map.gif"
              alt="The domain model of a sample XAF application. Hovering an entity dims everything it does not touch, leaving only its own relationships lit."
              loading="lazy" style="display:block;width:100%;height:auto">
       </div>
@@ -1076,7 +1076,7 @@ <h2>Most teams have never seen<br>their own domain model.</h2>
 
     <figure class="figure">
       <div class="fig-frame">
-        <img src="https://raw.githubusercontent.com/peopleworks/XAFLogicExplainer/main/docs/assets/explainer-entity.png"
+        <img src="assets/explainer-entity.png"
              alt="An entity card: every property with its type, which ones are calculated and the expression behind each, and the relationships with the ones whose parent owns the child marked as owned."
              loading="lazy" style="display:block;width:100%;height:auto">
       </div>
@@ -1088,7 +1088,7 @@ <h2>Most teams have never seen<br>their own domain model.</h2>
 
     <figure class="figure">
       <div class="fig-frame">
-        <img src="https://raw.githubusercontent.com/peopleworks/XAFLogicExplainer/main/docs/assets/explainer-criteria.png"
+        <img src="assets/explainer-criteria.png"
              alt="The criteria index: every criteria expression in the application in one table, each with the attribute and entity it came from."
              loading="lazy" style="display:block;width:100%;height:auto">
       </div>