Fix controls always being interactive even when hidden

Author: peppy

osu.Game/Screens/Play/HUD/ReplayOverlay.cs

@@ -20,18 +20,18 @@ public partial class ReplayOverlay : CompositeDrawable, IKeyBindingHandler<Globa
 
         private Bindable<bool> configSettingsOverlay = null!;
         private Container messageContainer = null!;
+        private Container content = null!;
 
         [BackgroundDependencyLoader]
         private void load(OsuConfigManager config)
         {
             RelativeSizeAxes = Axes.Both;
-            AlwaysPresent = true;
-            Alpha = 0;
 
             configSettingsOverlay = config.GetBindable<bool>(OsuSetting.ReplaySettingsOverlay);
 
-            InternalChild = new Container
+            InternalChild = content = new Container
             {
+                Alpha = 0,
                 RelativeSizeAxes = Axes.Both,
                 Children = new Drawable[]
                 {
@@ -54,9 +54,9 @@ protected override void LoadComplete()
         private void updateVisibility()
         {
             if (configSettingsOverlay.Value)
-                Show();
+                content.FadeIn(fade_duration, Easing.OutQuint);
             else
-                Hide();
+                content.FadeOut(fade_duration, Easing.OutQuint);
         }
 
         public bool OnPressed(KeyBindingPressEvent<GlobalAction> e)