Add warning display when player loading is paused due to user interaction

As touched on in ppy#37082.

15 minute task fixing a UX which was definitely not as visible as it
should have been.

Author: peppy

osu.Game/Screens/Play/BeatmapMetadataDisplay.cs

@@ -8,6 +8,7 @@
 using osu.Framework.Bindables;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
+using osu.Framework.Graphics.Shapes;
 using osu.Framework.Graphics.Sprites;
 using osu.Framework.Localisation;
 using osu.Game.Beatmaps;
@@ -19,6 +20,7 @@
 using osu.Game.Rulesets.Mods;
 using osu.Game.Screens.Play.HUD;
 using osuTK;
+using osuTK.Graphics;
 using CommonStrings = osu.Game.Localisation.CommonStrings;
 
 namespace osu.Game.Screens.Play
@@ -32,6 +34,7 @@ public partial class BeatmapMetadataDisplay : Container
         private readonly Bindable<IReadOnlyList<Mod>> mods;
         private readonly Drawable logoFacade;
         private LoadingSpinner loading;
+        private Drawable blockingLoadLayer;
 
         public IBindable<IReadOnlyList<Mod>> Mods => mods;
 
@@ -46,6 +49,30 @@ public bool Loading
             }
         }
 
+        private bool userBlocked;
+
+        public bool UserBlocked
+        {
+            set
+            {
+                if (value == userBlocked)
+                    return;
+
+                userBlocked = value;
+
+                if (userBlocked)
+                {
+                    blockingLoadLayer
+                        .FadeIn(300, Easing.Out)
+                        .Then()
+                        .FadeTo(0.5f, 1000, Easing.In)
+                        .Loop();
+                }
+                else
+                    blockingLoadLayer.FadeOut(500, Easing.OutQuint);
+            }
+        }
+
         public BeatmapMetadataDisplay(IWorkingBeatmap beatmap, Bindable<IReadOnlyList<Mod>> mods, Drawable logoFacade)
         {
             this.beatmap = beatmap;
@@ -61,7 +88,7 @@ public BeatmapMetadataDisplay(IWorkingBeatmap beatmap, Bindable<IReadOnlyList<Mo
         private StarRatingDisplay starRatingDisplay;
 
         [BackgroundDependencyLoader]
-        private void load(BeatmapDifficultyCache difficultyCache)
+        private void load(BeatmapDifficultyCache difficultyCache, OsuColour colours)
         {
             var metadata = beatmap.BeatmapInfo.Metadata;
 
@@ -117,7 +144,28 @@ private void load(BeatmapDifficultyCache difficultyCache)
                                 loading = new LoadingLayer(dimBackground: true)
                                 {
                                     BlockPositionalInput = false,
-                                }
+                                },
+                                blockingLoadLayer = new Container
+                                {
+                                    RelativeSizeAxes = Axes.Both,
+                                    Alpha = 0,
+                                    Children = new Drawable[]
+                                    {
+                                        new Box
+                                        {
+                                            Colour = colours.PinkDarker,
+                                            Alpha = 0.5f,
+                                            RelativeSizeAxes = Axes.Both,
+                                        },
+                                        new OsuSpriteText
+                                        {
+                                            Anchor = Anchor.Centre,
+                                            Origin = Anchor.Centre,
+                                            Font = OsuFont.Style.Heading2,
+                                            Text = "Loading paused.."
+                                        }
+                                    }
+                                },
                             }
                         },
                         versionFlow = new FillFlowContainer

osu.Game/Screens/Play/PlayerLoader.cs

@@ -120,22 +120,7 @@ protected bool BackgroundBrightnessReduction
             }
         }
 
-        private bool readyForPush =>
-            !playerConsumed
-            // don't push unless the player is completely loaded
-            && CurrentPlayer?.LoadState == LoadState.Ready
-            // don't push unless the player is ready to start gameplay
-            && ReadyForGameplay;
-
-        protected virtual bool ReadyForGameplay =>
-            // not ready if the user is hovering one of the panes (logo is excluded), unless they are idle.
-            (IsHovered || osuLogo?.IsHovered == true || idleTracker.IsIdle.Value)
-            // not ready if the user is dragging a slider or otherwise.
-            && (inputManager.DraggedDrawable == null || inputManager.DraggedDrawable is OsuLogo)
-            // not ready if a focused overlay is visible, like settings.
-            && inputManager.FocusedDrawable is not OsuFocusedOverlayContainer
-            // or if a child of a focused overlay is focused, like settings' search textbox.
-            && inputManager.FocusedDrawable?.FindClosestParent<OsuFocusedOverlayContainer>() == null;
+        protected virtual bool ReadyForGameplay { get; private set; }
 
         private bool holdForMenuExitButton => !AllowUserExit;
 
@@ -490,6 +475,18 @@ protected override void Update()
             if (!this.IsCurrentScreen())
                 return;
 
+            ReadyForGameplay =
+                // not ready if the user is hovering one of the panes (logo is excluded), unless they are idle.
+                (IsHovered || osuLogo?.IsHovered == true || idleTracker.IsIdle.Value)
+                // not ready if the user is dragging a slider or otherwise.
+                && (inputManager.DraggedDrawable == null || inputManager.DraggedDrawable is OsuLogo)
+                // not ready if a focused overlay is visible, like settings.
+                && inputManager.FocusedDrawable is not OsuFocusedOverlayContainer
+                // or if a child of a focused overlay is focused, like settings' search textbox.
+                && inputManager.FocusedDrawable?.FindClosestParent<OsuFocusedOverlayContainer>() == null;
+
+            MetadataInfo.UserBlocked = !ReadyForGameplay && CurrentPlayer?.LoadState == LoadState.Ready;
+
             // We need to perform this check here rather than in OnHover as any number of children of VisualSettings
             // may also be handling the hover events.
             if (inputManager.HoveredDrawables.Contains(VisualSettings) || QuickRestart)
@@ -654,6 +651,13 @@ private void pushWhenLoaded()
 
             if (!this.IsCurrentScreen()) return;
 
+            bool readyForPush =
+                !playerConsumed
+                // don't push unless the player is completely loaded
+                && CurrentPlayer?.LoadState == LoadState.Ready
+                // don't push unless the player is ready to start gameplay
+                && ReadyForGameplay;
+
             if (!readyForPush)
             {
                 // as the pushDebounce below has a delay, we need to keep checking and cancel a future debounce