Fix different C runtimes on Windows#84
Conversation
| } | ||
|
|
||
| // `cc` crate tracks target features when CMake just builds with dynamic C runtime | ||
| cfg.static_crt(false); |
There was a problem hiding this comment.
IMHO it is better to configure CMake accordingly. If I'm not mistaken build type should be set explicitly via https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html since the default value is empty string. RelWithDebInfo/Release should be a good choice.
For selecting static/dynamic runtime library the config variable https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html can be used.
There was a problem hiding this comment.
If I'm not mistaken build type should be set explicitly via cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html
cmake crate already handles it
the config variable cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html can be used.
Done
|
Hey thanks for this PR i was able to compile and use fine on windows ! |
3 participants
No description provided.