Apply suggestions from code review

Co-authored-by: yyyyyyy <contact@yyyyyyyan.tech>

Author: yyyyyyyan

scripts/check_alembic_revision_tree.py

@@ -125,7 +125,7 @@ def main(argv: list[str] | None = None) -> int:
     try:
         trees = inspect_revision_trees(args.ini)
     except (ValueError, OSError) as exc:
-        print(f"{args.ini}: {exc}", file=sys.stderr)
+        print(exc, file=sys.stderr)
         return 1
     failed = [tree for tree in trees if tree.is_forked]
     if not failed:

tests/scripts/test_check_alembic_revision_tree.py

@@ -82,7 +82,6 @@ def _write_ini(
     lines = [
         "[alembic]",
         f"databases = {databases}",
-        "version_path_separator = :",
         "",
         "[DEFAULT]",
         "path_separator = :",
@@ -180,19 +179,7 @@ def test_check_passes_on_reconverged_siblings(tmp_path, capsys):
     _write_revision(versions_dir, "base", None)
     _write_revision(versions_dir, "c1", "base")
     _write_revision(versions_dir, "c2", "base")
-    merge_template = """\
-revision = 'm'
-down_revision = ('c1', 'c2')
-branch_labels = None
-depends_on = None
-
-def upgrade():
-    pass
-
-def downgrade():
-    pass
-"""
-    (versions_dir / "m.py").write_text(merge_template, encoding="utf-8")
+    _write_revision(versions_dir, "m", ("c1", "c2"))
     ini_path = _write_ini(
         tmp_path,
         databases="widget",
@@ -211,17 +198,10 @@ def downgrade():
 
 def test_discovers_tracks_from_databases_key(tmp_path):
     """Discover track names from ``[alembic] databases``, not hard-coded lists."""
-    script_a = _dummy_script_location(tmp_path, "migrations_a")
-    script_b = _dummy_script_location(tmp_path, "migrations_b")
-    (script_a / "versions").mkdir()
-    (script_b / "versions").mkdir()
     ini_path = _write_ini(
         tmp_path,
         databases="widget, gadget",
-        sections={
-            "widget": {"script_location": str(script_a)},
-            "gadget": {"script_location": str(script_b)},
-        },
+        sections={"widget": {}, "gadget": {}},
     )
 
     assert check_alembic_revision_tree.list_track_names(ini_path) == (
@@ -316,16 +296,14 @@ def test_reintroducing_sep_1824_fork_fails(tmp_path, capsys):
     tree = trees[0]
     assert tree.name == "tasks"
     assert tree.is_forked is True
-    assert "a19da5cf0bca" in tree.heads
+    assert len(tree.heads) == len(tree.roots) + 1
     assert "e2f3a4b5c6d7" in tree.heads
 
     error = check_alembic_revision_tree.format_fork_error(tree)
     assert "tasks" in error
-    assert "a19da5cf0bca" in error
     assert "e2f3a4b5c6d7" in error
 
     assert check_alembic_revision_tree.main(["--ini", str(ini_path)]) == 1
     err = capsys.readouterr().err
     assert "tasks" in err
-    assert "a19da5cf0bca" in err
     assert "e2f3a4b5c6d7" in err