Skip to content

Commit 9e864d0

Browse files
authored
SEP-1844: Finish the two review points left half-applied
- Drop the ticket key from the 19 remaining spec fixture comments. The reviewer's suggestion covered only _template.spec.ts, and their point holds for the rest: the sentence carries itself, and repeating the key on identical boilerplate adds nothing. - Collapse the edit-guard comment to its cross-reference in both SchemaDrivenApp and AppTaskEditPage. AppCreatePage already spells out why the page is the control and why the back chrome stays, so the second line was restating it. My earlier repair of the mangled suggestion read the break as a lost comma and put the restatement back; the reviewer wanted it gone. Signed-off-by: Ignacio Durand <nachodurand@gmail.com>
1 parent c4efd08 commit 9e864d0

21 files changed

Lines changed: 21 additions & 23 deletions

frontend/packages/e2e/tests/alert-troubleshooting.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const MOCK_USER = {
2929
firstName: 'Smoke',
3030
lastName: 'Test',
3131
// Admin: the app pages under test render their create / execute / delete
32-
// controls only for a session that may mutate (SEP-1844).
32+
// controls only for a session that may mutate.
3333
isAdmin: true,
3434
};
3535

frontend/packages/e2e/tests/alerts.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const MOCK_USER = {
2828
firstName: 'Smoke',
2929
lastName: 'Test',
3030
// Admin: the app pages under test render their create / execute / delete
31-
// controls only for a session that may mutate (SEP-1844).
31+
// controls only for a session that may mutate.
3232
isAdmin: true,
3333
};
3434

frontend/packages/e2e/tests/alters.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const MOCK_USER = {
3030
firstName: 'Smoke',
3131
lastName: 'Test',
3232
// Admin: the app pages under test render their create / execute / delete
33-
// controls only for a session that may mutate (SEP-1844).
33+
// controls only for a session that may mutate.
3434
isAdmin: true,
3535
};
3636

frontend/packages/e2e/tests/app-disabled.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const MOCK_USER = {
4343
firstName: 'Smoke',
4444
lastName: 'Test',
4545
// Admin: the app pages under test render their create / execute / delete
46-
// controls only for a session that may mutate (SEP-1844).
46+
// controls only for a session that may mutate.
4747
isAdmin: true,
4848
};
4949

frontend/packages/e2e/tests/archives.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const MOCK_USER = {
3131
firstName: 'Smoke',
3232
lastName: 'Test',
3333
// Admin: the app pages under test render their create / execute / delete
34-
// controls only for a session that may mutate (SEP-1844).
34+
// controls only for a session that may mutate.
3535
isAdmin: true,
3636
};
3737

frontend/packages/e2e/tests/atw.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const MOCK_USER = {
3636
firstName: 'Smoke',
3737
lastName: 'Test',
3838
// Admin: the app pages under test render their create / execute / delete
39-
// controls only for a session that may mutate (SEP-1844).
39+
// controls only for a session that may mutate.
4040
isAdmin: true,
4141
};
4242

frontend/packages/e2e/tests/backup_mongo.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const MOCK_USER = {
4242
firstName: 'Smoke',
4343
lastName: 'Test',
4444
// Admin: the app pages under test render their create / execute / delete
45-
// controls only for a session that may mutate (SEP-1844).
45+
// controls only for a session that may mutate.
4646
isAdmin: true,
4747
};
4848

frontend/packages/e2e/tests/backup_pg.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const MOCK_USER = {
3535
firstName: 'Smoke',
3636
lastName: 'Test',
3737
// Admin: the app pages under test render their create / execute / delete
38-
// controls only for a session that may mutate (SEP-1844).
38+
// controls only for a session that may mutate.
3939
isAdmin: true,
4040
};
4141

frontend/packages/e2e/tests/inventory-schedules.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const MOCK_USER = {
3131
firstName: 'Smoke',
3232
lastName: 'Test',
3333
// Admin: the app pages under test render their create / execute / delete
34-
// controls only for a session that may mutate (SEP-1844).
34+
// controls only for a session that may mutate.
3535
isAdmin: true,
3636
};
3737

frontend/packages/e2e/tests/inventory-sync.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const MOCK_USER = {
2929
firstName: 'Smoke',
3030
lastName: 'Test',
3131
// Admin: the app pages under test render their create / execute / delete
32-
// controls only for a session that may mutate (SEP-1844).
32+
// controls only for a session that may mutate.
3333
isAdmin: true,
3434
};
3535

0 commit comments

Comments
 (0)