Skip to content

Commit e6234d7

Browse files
Copilotyyyyyyyan
andauthored
fix: reconcile main changes with strict type checking
Co-authored-by: yyyyyyyan <24644216+yyyyyyyan@users.noreply.github.com>
1 parent e9fe274 commit e6234d7

4 files changed

Lines changed: 11 additions & 4 deletions

File tree

app/sep/bundle_upload/factory.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _rebase_query(
8181
:param endpoint_query: The query pairs carried by the configured endpoint.
8282
:return: The merged query map.
8383
"""
84-
merged: dict[str, PlanValue] = {
84+
merged: dict[str, AnyStepValue] = {
8585
key: LiteralValue(source="literal", value=value)
8686
for key, value in endpoint_query.items()
8787
}

tests/app/sep/apps/mysql_backups/test_form_backfill.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,9 @@ def _repair(self, **overrides: object) -> dict[str, object] | None:
497497
def _repaired_format(self, **overrides: object) -> EncryptionFormat:
498498
repaired = self._repair(**overrides)
499499
assert repaired is not None
500-
return repaired["encryption_format"]
500+
repaired_format = repaired["encryption_format"]
501+
assert isinstance(repaired_format, EncryptionFormat)
502+
return repaired_format
501503

502504
@pytest.mark.parametrize(
503505
("stamped_fields", "expected"),
@@ -573,6 +575,7 @@ def test_the_repaired_stamp_validates_and_replaces_the_stored_one(self):
573575
outcome = _backfill_single_task(task, FORM_BACKFILL_ENTRIES[0], _ctx(lookup))
574576

575577
assert outcome.label == "repaired"
578+
assert outcome.stamped_data is not None
576579
assert (
577580
outcome.stamped_data[RESERVED_FORM_KEY]["encryption_format"]
578581
== EncryptionFormat.GPG

tests/app/sep/apps/mysql_backups/test_xtrabackup_encryption_format.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
import logging
2828
import types
29+
from typing import cast
2930

3031
import pytest
3132

@@ -40,7 +41,8 @@
4041
payload_method,
4142
)
4243

43-
_FORMATS = load_constant("ENCRYPTION_FORMATS")
44+
_FORMATS = cast(tuple[str, ...], load_constant("ENCRYPTION_FORMATS"))
45+
assert isinstance(_FORMATS, tuple)
4446
_resolve_encryption = load_function("_resolve_encryption")
4547

4648
_KEYFILE = "/keys/aes.key"

tests/app/sep/bundle_upload/test_plan.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2371,6 +2371,8 @@ async def test_search_runs_none_of_the_plans_resolution_steps(self, api: RemoteA
23712371
async with api:
23722372
await executor.search_cases("CS00")
23732373

2374-
requested = [str(key[1]) for key in mock.requests]
2374+
requested = [
2375+
str(key[1]) for key, calls in mock.requests.items() for _ in calls
2376+
]
23752377

23762378
assert requested == [_CASE_SEARCH_URL]

0 commit comments

Comments
 (0)