Fix for bug #1255371 Cacti monitoring scripts open multiple connections to the server

Author: roman-vynar

Changelog

@@ -1,8 +1,9 @@
-2013-11-26: version 1.1
+2013-12-16: version 1.1
 -------------------------
 * Added MySQL template for Zabbix 2.0.x (first release)
 * Added FreeBSD support to Nagios plugins, partially rewritten pmp-check-unix-memory (bugs 1249575, 1244081)
 * Added new options to ss_get_mysql_stats.php to better support pt-heartbeat (bugs 1253125, 1253130)
+* ss_get_mysql_stats.php script was opening multiple connections to the server (bug 1255371)
 * sql query for idle_blocker_duraction check in pmp-check-mysql-innodb did not conform sql mode of ONLY_FULL_GROUP_BY (bug #1240417)
 
 2013-10-02: version 1.0.5

cacti/scripts/ss_get_mysql_stats.php

@@ -232,39 +232,19 @@ function parse_cmdline( $args ) {
 # top of this file.
 # ============================================================================
 function ss_get_mysql_stats( $options ) {
-   # Process connection options and connect to MySQL.
+   # Process connection options.
    global $debug, $mysql_user, $mysql_pass, $cache_dir, $poll_time, $chk_options,
           $mysql_port, $mysql_ssl, $mysql_ssl_key, $mysql_ssl_cert, $mysql_ssl_ca, 
           $heartbeat, $heartbeat_table, $heartbeat_server_id, $heartbeat_utc;
 
-   # Connect to MySQL.
    $user = isset($options['user']) ? $options['user'] : $mysql_user;
    $pass = isset($options['pass']) ? $options['pass'] : $mysql_pass;
    $host = $options['host'];
    $port = isset($options['port']) ? $options['port'] : $mysql_port;
    $heartbeat_server_id = isset($options['server-id']) ? $options['server-id'] : $heartbeat_server_id;
-   debug(array('connecting to', $host, $port, $user, $pass));
-   if ( !extension_loaded('mysqli') ) {
-      debug("The MySQLi extension is not loaded");
-      die("The MySQLi extension is not loaded");
-   }
-   if ( $mysql_ssl ) {
-      $conn = mysqli_init();
-      mysqli_ssl_set($conn, $mysql_ssl_key, $mysql_ssl_cert, $mysql_ssl_ca, NULL, NULL);
-      mysqli_real_connect($conn, $host, $user, $pass, NULL, $port);
-   }
-   else {
-      $conn = mysqli_connect($host, $user, $pass, NULL, $port);
-   }
-   if ( !$conn ) {
-      debug("MySQL connection failed: " . mysqli_error());
-      die("MySQL: " . mysqli_error());
-   }
 
-   $sanitized_host
-       = str_replace(array(":", "/"), array("", "_"), $options['host']);
-   $cache_file = "$cache_dir/$sanitized_host-mysql_cacti_stats.txt"
-               . (isset($options['port']) || $port != 3306 ? ":$port" : '');
+   $sanitized_host = str_replace(array(":", "/"), array("", "_"), $host);
+   $cache_file = "$cache_dir/$sanitized_host-mysql_cacti_stats.txt" . ($port != 3306 ? ":$port" : '');
    debug("Cache file is $cache_file");
 
    # First, check the cache.
@@ -314,6 +294,25 @@ function ss_get_mysql_stats( $options ) {
       debug("Not using the cache file");
    }
 
+   # Connect to MySQL.
+   debug(array('Connecting to', $host, $port, $user, $pass));
+   if ( !extension_loaded('mysqli') ) {
+      debug("PHP MySQLi extension is not loaded");
+      die("PHP MySQLi extension is not loaded");
+   }
+   if ( $mysql_ssl ) {
+      $conn = mysqli_init();
+      mysqli_ssl_set($conn, $mysql_ssl_key, $mysql_ssl_cert, $mysql_ssl_ca, NULL, NULL);
+      mysqli_real_connect($conn, $host, $user, $pass, NULL, $port);
+   }
+   else {
+      $conn = mysqli_connect($host, $user, $pass, NULL, $port);
+   }
+   if ( mysqli_connect_errno() ) {
+      debug("MySQL connection failed: " . mysqli_connect_error());
+      die("ERROR: " . mysqli_connect_error());
+   }
+
    # Set up variables.
    $status = array( # Holds the result of SHOW STATUS, SHOW INNODB STATUS, etc
       # Define some indexes so they don't cause errors with += operations.

docs/zabbix/index.rst

@@ -83,7 +83,7 @@ the Agent node.
      [root@centos6 ~]# /var/lib/zabbix/percona/scripts/get_mysql_stats_wrapper.sh gg
      ERROR: run the command manually to investigate the problem: /usr/bin/php -q /var/lib/zabbix/percona/scripts/ss_get_mysql_stats.php --host localhost --items gg
      [root@centos6 ~]# /usr/bin/php -q /var/lib/zabbix/percona/scripts/ss_get_mysql_stats.php --host localhost --items gg
-     MySQL: [root@centos6 ~]# 
+     ERROR: Can't connect to local MySQL server through socket '/var/lib/mysql/mysql.sock' (2)[root@centos6 ~]# 
 
 3. Configure /root/.my.cnf