Replace finalizers instead of removing to avoid conflicts

Author: valmiranogueira

e2e-tests/functions

@@ -132,7 +132,7 @@ function remove_all_finalizers() {
 			if [[ $(kubectl -n "${NAMESPACE}" get "$resource" "$name" -o yaml | yq '.metadata.finalizers | length') == "0" ]]; then
 				continue
 			fi
-			kubectl -n "${NAMESPACE}" patch "$resource" "$name" --type=json -p='[{"op": "remove", "path": "/metadata/finalizers"}]'
+			kubectl -n "${NAMESPACE}" patch "$resource" "$name" --type=json -p='[{"op":"replace","path":"/metadata/finalizers","value":[]}]'
 			kubectl -n "${NAMESPACE}" delete "$resource" "$name" --wait=0
 		done
 	done

e2e-tests/tests/migration-from-crunchy-backup-restore/99-cleanup.yaml

@@ -20,7 +20,7 @@ commands:
 
       kubectl delete postgrescluster crunchy-source -n "${CRUNCHY_NS}" --ignore-not-found || true
       kubectl patch postgrescluster crunchy-source -n "${CRUNCHY_NS}" \
-        --type=json -p='[{"op":"remove","path":"/metadata/finalizers"}]' 2>/dev/null || true
+        --type=json -p='[{"op":"replace","path":"/metadata/finalizers","value":[]}]' 2>/dev/null || true
 
       helm uninstall pgo --namespace "${CRUNCHY_NS}" --ignore-not-found || true
 

e2e-tests/tests/migration-from-crunchy-pv/03-migrate-pv.yaml

@@ -50,7 +50,7 @@ commands:
       # 3. Delete the Crunchy cluster and operator — no longer needed once the PV
       #    is retained.  Strip finalizers first so the CR is removed cleanly.
       kubectl patch postgrescluster crunchy-source -n "${NAMESPACE}" \
-        --type=json -p='[{"op":"remove","path":"/metadata/finalizers"}]' 2>/dev/null || true
+        --type=json -p='[{"op":"replace","path":"/metadata/finalizers","value":[]}]' 2>/dev/null || true
 
       kubectl delete postgrescluster crunchy-source -n "${NAMESPACE}" --ignore-not-found
 

e2e-tests/tests/migration-from-crunchy-pv/99-cleanup.yaml

@@ -19,7 +19,7 @@ commands:
       # Remove Crunchy source cluster if it still exists (e.g. test failed
       # before step 03 could delete it).
       kubectl patch postgrescluster crunchy-source -n "${NAMESPACE}" \
-        --type=json -p='[{"op":"remove","path":"/metadata/finalizers"}]' 2>/dev/null || true
+        --type=json -p='[{"op":"replace","path":"/metadata/finalizers","value":[]}]' 2>/dev/null || true
       kubectl delete postgrescluster crunchy-source -n "${NAMESPACE}" \
         --ignore-not-found || true
 

e2e-tests/tests/migration-from-crunchy-standby/99-cleanup.yaml

@@ -22,7 +22,7 @@ commands:
       # Strip finalizers so deletion is not blocked by a missing operator
       kubectl delete postgrescluster crunchy-source -n "${CRUNCHY_NS}" --ignore-not-found || true
       kubectl patch postgrescluster crunchy-source -n "${CRUNCHY_NS}" \
-        --type=json -p='[{"op":"remove","path":"/metadata/finalizers"}]' 2>/dev/null || true
+        --type=json -p='[{"op":"replace","path":"/metadata/finalizers","value":[]}]' 2>/dev/null || true
 
       helm uninstall pgo --namespace "${CRUNCHY_NS}" --ignore-not-found || true
       kubectl delete namespace "${CRUNCHY_NS}" --ignore-not-found || true