Skip to content

Cannot add custom labels for PostgreSQL metrics sent to PMM #691

Open
@konoox

Description

@konoox

Proposal

As far as I know, the CR definition of Percona PostgreSQL cluster does not provide any configuration attribute to add custom labels to the metrics sent to the PMM server from pmm-client containers.
This is possible with Percona MongoDB clusters using spec.pmm.mongodParams and spec.pmm.mongosParams, but also with Percona XtraDB clusters using spec.pmm.pxcParams and spec.proxysqlParams.

Use-Case

The additional flags, in my case custom labels, are added to the "pmm-admin add" options through the PMM_ADMIN_CUSTOM_PARAMS environment variable in the prerun script :

Psmdb definition :

kind: PerconaServerMongoDB

spec:
pmm:
mongodParams: --custom-labels=namespace=my-namespace

Mongo pod definition :

  • name: PMM_ADMIN_CUSTOM_PARAMS
    value: --custom-labels=namespace=my-namespace
  • name: PMM_AGENT_PRERUN_SCRIPT
    value: |-
    cat /etc/mongodb-ssl/tls.key /etc/mongodb-ssl/tls.crt > /tmp/tls.pem;
    pmm-admin status --wait=10s;
    pmm-admin add $(DB_TYPE) $(PMM_ADMIN_CUSTOM_PARAMS) …

It would be a great feature to implement this for the Percona PostgreSQL operator as well !

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions