Skip to content

Commit ece2836

Browse files
committed
Rename GetSANsFromCert to GetDNSNamesFromCert
The function returns only cert.DNSNames, not all SAN types. Renaming to match actual behavior per PR review feedback.
1 parent 5492dc7 commit ece2836

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

pkg/controller/perconaservermongodb/ssl.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ func (r *ReconcilePerconaServerMongoDB) needsManualSSLUpdate(ctx context.Context
531531
return false
532532
}
533533

534-
currentSANs, err := tls.GetSANsFromCert(sslSecret.Data["tls.crt"])
534+
currentSANs, err := tls.GetDNSNamesFromCert(sslSecret.Data["tls.crt"])
535535
if err != nil {
536536
return false
537537
}

pkg/psmdb/tls/manual_tls_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ func TestIssueWithCA_InvalidInputs(t *testing.T) {
146146
})
147147
}
148148

149-
func TestGetSANsFromCert(t *testing.T) {
149+
func TestGetDNSNamesFromCert(t *testing.T) {
150150
hosts := []string{"localhost", "mongo-0.example.com", "*.mongo.ns"}
151151

152152
caCert, caKey, err := IssueCA()
@@ -155,19 +155,19 @@ func TestGetSANsFromCert(t *testing.T) {
155155
tlsCert, _, err := IssueWithCA(hosts, caCert, caKey)
156156
require.NoError(t, err)
157157

158-
sans, err := GetSANsFromCert(tlsCert)
158+
sans, err := GetDNSNamesFromCert(tlsCert)
159159
require.NoError(t, err)
160160

161161
sort.Strings(sans)
162162
sort.Strings(hosts)
163163
assert.Equal(t, hosts, sans)
164164
}
165165

166-
func TestGetSANsFromCert_InvalidInput(t *testing.T) {
167-
_, err := GetSANsFromCert([]byte("not-a-cert"))
166+
func TestGetDNSNamesFromCert_InvalidInput(t *testing.T) {
167+
_, err := GetDNSNamesFromCert([]byte("not-a-cert"))
168168
assert.Error(t, err)
169169

170-
_, err = GetSANsFromCert(nil)
170+
_, err = GetDNSNamesFromCert(nil)
171171
assert.Error(t, err)
172172
}
173173

pkg/psmdb/tls/tls.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,8 @@ func Issue(hosts []string) (caCert []byte, tlsCert []byte, tlsKey []byte, err er
185185
return caCertPEM, tlsCertPEM, tlsKeyPEM, nil
186186
}
187187

188-
// GetSANsFromCert extracts DNS SANs from a PEM-encoded TLS certificate.
189-
func GetSANsFromCert(tlsCertPEM []byte) ([]string, error) {
188+
// GetDNSNamesFromCert extracts DNS names from the SANs of a PEM-encoded TLS certificate.
189+
func GetDNSNamesFromCert(tlsCertPEM []byte) ([]string, error) {
190190
block, _ := pem.Decode(tlsCertPEM)
191191
if block == nil {
192192
return nil, fmt.Errorf("failed to decode TLS certificate PEM")

0 commit comments

Comments
 (0)