Resolve semantic conflicts for merge '03913d95ace' into 'master'#2047
Merged
igorsol merged 1 commit intoJul 23, 2026
Merged
Conversation
…ter' Root-cause bucket (a): upstream commit da815a7 (SERVER-131455) changed catalog::initializeCollectionCatalog to require an InitMode argument, dropping the old 2-arg overload. The Percona-specific FCBIS code (initial_syncer_fcb.cpp) still called the removed 2-arg signature, so I adapted the call site to the new API instead of resurrecting the removed overload. Resolved: src/mongo/db/repl/initial_sync/initial_syncer_fcb.cpp CI: build-and-test run 30005247778 (attempt 1 of 2) Note: commit created by mergai
|
psmdb-bot[bot] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Info
master53f88a4bc714b63eb1aa478bd799b389aea3987803913d95ace6873f6cdd9513d984d16ce3453cffMerge Context
Important Files Modified
src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cppsrc/mongo/db/storage/wiredtiger/wiredtiger_kv_engine_test.cppAuto-Merged Files
buildscripts/resmokelib/core/programs.pysrc/mongo/db/auth/security_file.cppsrc/mongo/db/curop_test.cppsrc/mongo/db/index_builds/BUILD.bazelsrc/mongo/db/op_debug.cppsrc/mongo/db/pipeline/BUILD.bazelsrc/mongo/db/shard_role/shard_catalog/collection_catalog_helper.cppsrc/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cppMerged with strategy: ort
Show details
03913d95ace6873f6cdd9513d984d16ce3453cfffe82f6afeb60d1e5ef4d08389d0d3373b6bd5aca12f316663ed1c50ab1185d29addded4c0670116134c7f865648174254f3936d43ba6e9e9b9f5aabbf84183e6c1f55aa323e23f4e6c41e9f6eecf2162d30b6b9b1f5bae2d6c35f2e422fcb144b7c179bcb482f65b801670a874d8b2326043c6cfbf84cfc6fff5731508a1acac63fe8c66ece12639cac3c1b1c13e26499975c0fd36f6f52693293f030f4784b7446357072071db2c52c4f35e486a6eea8a5a448378bf45c3ec89652169becf4bc883efcdf3ceac8e3de4e0e37893de9dbd153ffd8d4156a46f8048f3968e13ea92aa65ab88bd5875f8279ea87bb2a8d1dfc37d709b7f0bd8d44ad70316939434d456e6bd3a2bd182fac784da4cda4c367edd72339b7bb0bdf82218cda1e043190aefc1f5a8f9b653dd369648f243c09d22b5ccdd4c3badfd6c630adc78a6314956d7912e94b86ba7791c80a3070366fdbc8a740dcd9d2cd6a636f351a17062fd7eb640a6ea98e72dd8ee8066a329d07e28c2ba98037c7ce1d13548b59027e93df18bbe778d45c4fa2ba4a39e2e94057b6b29ece426453b58d94b7398fd60e094ff5098fac237690bb8e94f0c6fd2e0b897df3a76d1fc7e76get_binary_version_outputto always resolve paths against the augmented PATH (#59055)6a9701993e4751b2e8a531ae1a722ede69fc3dd335066d7040845f44ae530d1296ab40b1864244ab195d1431c225917d9db57d88c80879c5a76253404bd1535ad38dd4389a28b92fc062426f9280c361c16374b2dbab5c02ae967a23aab6f485cf1769bcf142a2358f076f52bbb3d729f63f12ffb2057210dceab84ec3b87f352b96d52b43b30a70eeb1669b17103c77ca4a874f954edc91987e6c4c02aeb0dc65009a0b1b6b0a7630cb37775064b04a0ac69f7f4b6d9abdb75dc232193f18c70679ae1a200fb0213400d290530c6d38940d9a69b1d03ce75c15a890c35c9f5f44bf5aedab055c852d68e3a09fccf311de59bb98e2718b8963a0ac45967d83c8513c637314b4075ca1aeae22cb912200c400a0e77260374f3b24929edab9b41543f91253b7887d8d9df983d11f14239571955345dd3deb9208859d1059e5ff31da815a79cd8b37c5d628c2f0884b022fa5583d36281158640567c3e75cb0abf1962a1a0c21b1366755c106b5f41da165e72bcfcbc9cbc731e2987c1786a35f6b55d6c808299fdbd5239e2806335dfddceebe422b6a62007d7fd73b7cdc95d41e5dfc80e7850bb42a71deeaa9a6b51efcc55da9261025a8274002c003c00682780a61457657ed47df6bcd2685f1f40f66d13437540e0c3f4e3eaad0632660dbf7b79fd73434bbbe9092de3d48cf96de3962d74d99Merge Description
Summary
Merge of upstream mongodb-master into the fork. The incoming changes touch a handful of files: op_debug now reports LDAP operation stats as a distinct top-level "LDAPOperations" object (with a matching new unit test in curop_test.cpp), the security key-file parser no longer leaks the key contents in its error message, the resmoke binary-version helper resolves binaries via shutil.which against the augmented PATH, two BUILD.bazel files gain new dependencies, collection catalog initialization now passes an explicit InitMode::kStartup, and the WiredTiger record store now derives tracksSizeAdjustments from provider.shouldUseReplicatedFastCount() instead of always true.
Auto-Merged Files
buildscripts/resmokelib/core/programs.pymongodis located against the augmented PATH (multiversion and install directories).src/mongo/db/auth/security_file.cppsrc/mongo/db/curop_test.cppsrc/mongo/db/index_builds/BUILD.bazelsrc/mongo/db/op_debug.cppsrc/mongo/db/pipeline/BUILD.bazelsrc/mongo/db/shard_role/shard_catalog/collection_catalog_helper.cppsrc/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cppReview Notes
All listed files auto-merged cleanly (ort strategy); the changes above are upstream-only additions relative to the diff base and do not appear to touch Percona-specific code. The wiredtiger_kv_engine.cpp change depends on a provider.shouldUseReplicatedFastCount() API introduced upstream — verify that symbol resolves in the merged tree. The op_debug.cpp change is a functional change to profiler/log output format (LDAPOperations becomes its own top-level object); confirm no fork tooling parses the old nested layout.
Agent Stats
Agent: claude_cli (version 2.1.218 (Claude Code))
Solutions
Solution 1
Summary
Root-cause bucket (a): upstream commit da815a7 (SERVER-131455) changed catalog::initializeCollectionCatalog to require an InitMode argument, dropping the old 2-arg overload. The Percona-specific FCBIS code (initial_syncer_fcb.cpp) still called the removed 2-arg signature, so I adapted the call site to the new API instead of resurrecting the removed overload.
By: Agent (claude_cli v2.1.218 (Claude Code))
Resolved Files
src/mongo/db/repl/initial_sync/initial_syncer_fcb.cppUnresolved Files
All conflicts have been resolved.
Modified Files
No additional files were modified.
Review Notes
The build only reported initial_syncer_fcb.cpp:1578. I searched the whole tree with
initializeCollectionCatalog\(and confirmed every other call site (storage_engine_test.cpp, catalog_control.cpp, collection_catalog_helper.cpp, feature_compatibility_version_test.cpp) already passes an InitMode, so this was the only stale caller. I chose kStorageChange (rather than kRollback/kStartup) because the FCBIS flow here calls reinitializeStorageEngine to swap dbpath to a new location — a storage change — matching the intent of the upstream fix whose title is literally 'Fix HistoricalCatalogIdTracker incorrect results after FCBIS'. Worth a quick confirmation that kStorageChange (which resets the catalogIdTracker) is desired here rather than preserving tracker history.Agent Stats
Agent: claude_cli (version 2.1.218 (Claude Code))
note created with mergai 0.1.dev1+g07faa5a05