Skip to content

Commit b1ff1e8

Browse files
authored
Merge pull request #228 from performant-software/RB-null-geometry-detail-panel-bug
Fixing null geometry detail panel crash
2 parents b1129ca + b06ea24 commit b1ff1e8

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/apps/search/panels/BasePanel.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,10 @@ const { data: { people = [] } = {}, loading: peopleLoading } = useLoader(onLoadP
214214
return props.resolveGeometry(item);
215215
}
216216

217-
return !_.isEmpty(places) && CoreDataUtils.toFeatureCollection(places);
217+
return !_.isEmpty(places.filter((place) => place.place_geometry)) &&
218+
CoreDataUtils.toFeatureCollection(
219+
places.filter((place) => place.place_geometry)
220+
);
218221
}, [item, places, props.resolveGeometry]);
219222

220223
/**

src/apps/search/panels/Place.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const Place = (props: Props) => {
4848
</>
4949
)}
5050
resolveDetailPageUrl={resolveDetailPageUrl}
51-
resolveGeometry={(place) => CoreDataUtils.toFeatureCollection([place])}
51+
resolveGeometry={(place) => place?.place_geometry && CoreDataUtils.toFeatureCollection([place])}
5252
service={PlacesService}
5353
/>
5454
);

0 commit comments

Comments
 (0)