Fix viewer-charts context sharing and misc bugs
#1750
Annotations
4 errors, 1 warning, and 1 notice
|
Run Tests
Process completed with exit code 1.
|
|
Run Tests:
tools/test/src/js/utils.ts#L193
2) [viewer-datagrid-desktop-chrome] › packages/viewer-datagrid/test/js/column_style.spec.ts:261:5 › Column Style Tests › Column style label-bar on an expression column
Error: expect(string).toMatchSnapshot(expected) failed
@@ -12,18 +12,18 @@
>
<span>Order ID</span><span class="rt-column-resize"></span>
</th>
</tr>
<tr id="psp-column-edit-buttons">
- <th class="psp-menu-enabled psp-header-leaf psp-align-right">
+ <th class="psp-header-leaf psp-align-right psp-menu-enabled">
<span></span><span class="rt-column-resize"></span>
</th>
- <th class="psp-menu-enabled psp-header-leaf psp-align-right">
+ <th class="psp-header-leaf psp-align-right psp-menu-enabled">
<span></span><span class="rt-column-resize"></span>
</th>
<th
- class="psp-header-border psp-menu-enabled psp-header-leaf psp-align-left"
+ class="psp-header-border psp-header-leaf psp-align-left psp-menu-enabled"
>
<span></span><span class="rt-column-resize"></span>
</th>
</tr>
</thead>
Snapshot: column-style-tests-column-style-label-bar-on-an-expression-column.txt
at src/js/utils.ts:193
191 |
192 | snapshotPath = `${snapshotPath}.txt`;
> 193 | await expect(formatted).toMatchSnapshot(snapshotPath);
| ^
194 | }
195 |
196 | export async function compareSVGContentsToSnapshot(
at compareContentsToSnapshot (/home/runner/work/perspective/perspective/tools/test/src/js/utils.ts:193:29)
at /home/runner/work/perspective/perspective/packages/viewer-datagrid/test/js/column_style.spec.ts:289:9
|
|
Run Tests:
rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts#L83
1) [viewer-desktop-chrome] › rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:62:5 › Column Settings Sidebar › edit button > opens sidebar for active table and expression columns
TimeoutError: locator.click: Timeout 5000ms exceeded.
Call log:
- waiting for locator('perspective-viewer').locator('#active-columns :not(.top-panel) .column-selector-column').filter({ hasText: 'expr' }).first().locator('div .expression-edit-button')
81 | await activeColumns.scrollToBottom();
82 | exprCol.editBtn.waitFor();
> 83 | await exprCol.editBtn.click();
| ^
84 | await checkTab(view.columnSettingsSidebar, true, true);
85 | });
86 | test("edit button > opens sidebar for inactive expression columns", async ({
at /home/runner/work/perspective/perspective/rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:83:31
|
|
Run Tests:
rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts#L82
1) [viewer-desktop-chrome] › rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:62:5 › Column Settings Sidebar › edit button > opens sidebar for active table and expression columns
TimeoutError: locator.waitFor: Timeout 5000ms exceeded.
Call log:
- waiting for locator('perspective-viewer').locator('#active-columns :not(.top-panel) .column-selector-column').filter({ hasText: 'expr' }).first().locator('div .expression-edit-button') to be visible
80 |
81 | await activeColumns.scrollToBottom();
> 82 | exprCol.editBtn.waitFor();
| ^
83 | await exprCol.editBtn.click();
84 | await checkTab(view.columnSettingsSidebar, true, true);
85 | });
at /home/runner/work/perspective/perspective/rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:82:25
|
|
Complete job
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/upload-artifact@v4, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Run Tests
2 failed
[viewer-desktop-chrome] › rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:62:5 › Column Settings Sidebar › edit button > opens sidebar for active table and expression columns
[viewer-datagrid-desktop-chrome] › packages/viewer-datagrid/test/js/column_style.spec.ts:261:5 › Column Style Tests › Column style label-bar on an expression column
118 skipped
1720 passed (4.4m)
|
background
wait
wait-all
cancel
parallel
Loading