Skip to content

Commit 2096ed8

Browse files
authored
Merge pull request #2289 from finos/fix-typescript-5-bundler-support
Fix TypeScript 5 `moduleResolution: "bundler"` support
2 parents c75d8b0 + 476dfc3 commit 2096ed8

7 files changed

Lines changed: 48 additions & 28 deletions

File tree

examples/react-example/tsconfig.json

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"compilerOptions": {
3-
"moduleResolution": "node",
3+
"moduleResolution": "bundler",
44
"target": "es5",
55
"lib": ["es6", "dom"],
66
"module": "esnext",
@@ -26,8 +26,6 @@
2626
"experimentalDecorators": true,
2727
"downlevelIteration": true,
2828
"pretty": true
29-
},
30-
"exclude": [
31-
"node_modules",
32-
]
33-
}
29+
},
30+
"exclude": ["node_modules"]
31+
}

examples/react-example/webpack.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ module.exports = {
4444
],
4545
},
4646
devServer: {
47-
contentBase: [
47+
static: [
4848
path.join(__dirname, "dist"),
4949
path.join(__dirname, "../../node_modules/superstore-arrow"),
5050
],

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@
7474
"tiny-glob": "^0.2.9",
7575
"ts-loader": "^6.2.0",
7676
"ts-node": "^10.9.1",
77-
"typedoc": "^0.23.0",
77+
"typedoc": "^0.24.8",
7878
"typedoc-plugin-markdown": "^3.14.0",
7979
"typedoc-plugin-no-inherit": "^1.4.0",
80-
"typescript": "4.9.4",
80+
"typescript": "5.1.6",
8181
"webpack": "^5.60.0",
8282
"webpack-cli": "^4.7.0",
8383
"webpack-dev-server": "^4.11.1"

packages/perspective-cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"src/**/*",
1111
"perspective"
1212
],
13-
"typings": "index.d.ts",
13+
"types": "index.d.ts",
1414
"scripts": {
1515
"clean": "rimraf build"
1616
},

packages/perspective/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"jsdelivr": "dist/cdn/perspective.js",
1313
"exports": {
1414
".": {
15+
"types": "./index.d.ts",
1516
"node": "./dist/cjs/perspective.node.js",
1617
"default": "./dist/esm/perspective.inline.js"
1718
},

rust/perspective-viewer/package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@
1010
"unpkg": "dist/cdn/perspective-viewer.js",
1111
"jsdelivr": "dist/cdn/perspective-viewer.js",
1212
"exports": {
13-
".": "./dist/esm/perspective-viewer.inline.js",
13+
".": {
14+
"types": "./dist/esm/perspective-viewer.d.ts",
15+
"default": "./dist/esm/perspective-viewer.inline.js"
16+
},
1417
"./dist/*": "./dist/*",
1518
"./src/*": "./src/*",
1619
"./test/*": "./test/*",

yarn.lock

Lines changed: 35 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5073,6 +5073,11 @@ ansi-regex@^6.0.1:
50735073
resolved "https://registry.yarnpkg.com/ansi-regex/-/ansi-regex-6.0.1.tgz#3183e38fae9a65d7cb5e53945cd5897d0260a06a"
50745074
integrity sha512-n5M855fKb2SsfMIiFFoVrABHJC8QtHwVx+mHWP3QcEqBHYienj5dHSgjbxtC0WEZXYt4wcD6zrQElDPhFuZgfA==
50755075

5076+
ansi-sequence-parser@^1.1.0:
5077+
version "1.1.1"
5078+
resolved "https://registry.yarnpkg.com/ansi-sequence-parser/-/ansi-sequence-parser-1.1.1.tgz#e0aa1cdcbc8f8bb0b5bca625aac41f5f056973cf"
5079+
integrity sha512-vJXt3yiaUL4UU546s3rPXlsry/RnM730G1+HkpKE012AN0sx1eOrxSu95oKDIonskeLTijMgqWZ3uDEe3NFvyg==
5080+
50765081
ansi-styles@^2.2.1:
50775082
version "2.2.1"
50785083
resolved "https://registry.yarnpkg.com/ansi-styles/-/ansi-styles-2.2.1.tgz#b432dd3358b634cf75e1e4664368240533c1ddbe"
@@ -11096,7 +11101,7 @@ markdown-it@^12.3.2:
1109611101
mdurl "^1.0.1"
1109711102
uc.micro "^1.0.5"
1109811103

11099-
marked@^4.0.10, marked@^4.2.3, marked@^4.2.5:
11104+
marked@^4.0.10, marked@^4.2.3:
1110011105
version "4.2.5"
1110111106
resolved "https://registry.yarnpkg.com/marked/-/marked-4.2.5.tgz#979813dfc1252cc123a79b71b095759a32f42a5d"
1110211107
integrity sha512-jPueVhumq7idETHkb203WDD4fMA3yV9emQ5vLwop58lu8bTclMghBWcYAavlDqIEMaisADinV1TooIFCfqOsYQ==
@@ -11106,6 +11111,11 @@ marked@^4.0.17:
1110611111
resolved "https://registry.yarnpkg.com/marked/-/marked-4.2.12.tgz#d69a64e21d71b06250da995dcd065c11083bebb5"
1110711112
integrity sha512-yr8hSKa3Fv4D3jdZmtMMPghgVt6TWbk86WQaWhDloQjRSQhMMYCAro7jP7VDJrjjdV8pxVxMssXS8B8Y5DZ5aw==
1110811113

11114+
marked@^4.3.0:
11115+
version "4.3.0"
11116+
resolved "https://registry.yarnpkg.com/marked/-/marked-4.3.0.tgz#796362821b019f734054582038b116481b456cf3"
11117+
integrity sha512-PRsaiG84bK+AMvxziE/lCFss8juXjNaWzVbN5tXAm4XjeaS9NAHhop+PjQxz2A9h8Q4M/xGmzP8vqNwy6JeK0A==
11118+
1110911119
math-expression-evaluator@^1.2.14:
1111011120
version "1.3.7"
1111111121
resolved "https://registry.yarnpkg.com/math-expression-evaluator/-/math-expression-evaluator-1.3.7.tgz#1b62225db86af06f7ea1fd9576a34af605a5b253"
@@ -11373,6 +11383,13 @@ minimatch@^5.1.2:
1137311383
dependencies:
1137411384
brace-expansion "^2.0.1"
1137511385

11386+
minimatch@^9.0.0:
11387+
version "9.0.3"
11388+
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-9.0.3.tgz#a6e00c3de44c3a542bfaae70abfc22420a6da825"
11389+
integrity sha512-RHiac9mvaRw0x3AYRgDC1CxAP7HTcNrrECeA8YYJeWnpo+2Q5CegtZjaotWTWxDG3UeGA1coE05iH1mPjT/2mg==
11390+
dependencies:
11391+
brace-expansion "^2.0.1"
11392+
1137611393
minimatch@~3.0.4:
1137711394
version "3.0.8"
1137811395
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-3.0.8.tgz#5e6a59bd11e2ab0de1cfb843eb2d82e546c321c1"
@@ -14526,11 +14543,12 @@ shelljs@^0.8.5:
1452614543
interpret "^1.0.0"
1452714544
rechoir "^0.6.2"
1452814545

14529-
shiki@^0.12.1:
14530-
version "0.12.1"
14531-
resolved "https://registry.yarnpkg.com/shiki/-/shiki-0.12.1.tgz#26fce51da12d055f479a091a5307470786f300cd"
14532-
integrity sha512-aieaV1m349rZINEBkjxh2QbBvFFQOlgqYTNtCal82hHj4dDZ76oMlQIX+C7ryerBTDiga3e5NfH6smjdJ02BbQ==
14546+
shiki@^0.14.1:
14547+
version "0.14.3"
14548+
resolved "https://registry.yarnpkg.com/shiki/-/shiki-0.14.3.tgz#d1a93c463942bdafb9866d74d619a4347d0bbf64"
14549+
integrity sha512-U3S/a+b0KS+UkTyMjoNojvTgrBHjgp7L6ovhFVZsXmBGnVdQ4K4U9oK0z63w538S91ATngv1vXigHCSWOwnr+g==
1453314550
dependencies:
14551+
ansi-sequence-parser "^1.1.0"
1453414552
jsonc-parser "^3.2.0"
1453514553
vscode-oniguruma "^1.7.0"
1453614554
vscode-textmate "^8.0.0"
@@ -15580,20 +15598,20 @@ typedoc-plugin-no-inherit@^1.4.0:
1558015598
resolved "https://registry.yarnpkg.com/typedoc-plugin-no-inherit/-/typedoc-plugin-no-inherit-1.4.0.tgz#8eafc790588f63f0a24621b646219cd6e8d6e4d6"
1558115599
integrity sha512-cAvqQ8X9xh1xztVoDKtF4nYRSBx9XwttN3OBbNNpA0YaJSRM8XvpVVhugq8FoO1HdWjF3aizS0JzdUOMDt0y9g==
1558215600

15583-
typedoc@^0.23.0:
15584-
version "0.23.24"
15585-
resolved "https://registry.yarnpkg.com/typedoc/-/typedoc-0.23.24.tgz#01cf32c09f2c19362e72a9ce1552d6e5b48c4fef"
15586-
integrity sha512-bfmy8lNQh+WrPYcJbtjQ6JEEsVl/ce1ZIXyXhyW+a1vFrjO39t6J8sL/d6FfAGrJTc7McCXgk9AanYBSNvLdIA==
15601+
typedoc@^0.24.8:
15602+
version "0.24.8"
15603+
resolved "https://registry.yarnpkg.com/typedoc/-/typedoc-0.24.8.tgz#cce9f47ba6a8d52389f5e583716a2b3b4335b63e"
15604+
integrity sha512-ahJ6Cpcvxwaxfu4KtjA8qZNqS43wYt6JL27wYiIgl1vd38WW/KWX11YuAeZhuz9v+ttrutSsgK+XO1CjL1kA3w==
1558715605
dependencies:
1558815606
lunr "^2.3.9"
15589-
marked "^4.2.5"
15590-
minimatch "^5.1.2"
15591-
shiki "^0.12.1"
15592-
15593-
typescript@4.9.4:
15594-
version "4.9.4"
15595-
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.4.tgz#a2a3d2756c079abda241d75f149df9d561091e78"
15596-
integrity sha512-Uz+dTXYzxXXbsFpM86Wh3dKCxrQqUcVMxwU54orwlJjOpO3ao8L7j5lH+dWfTwgCwIuM9GQ2kvVotzYJMXTBZg==
15607+
marked "^4.3.0"
15608+
minimatch "^9.0.0"
15609+
shiki "^0.14.1"
15610+
15611+
typescript@5.1.6:
15612+
version "5.1.6"
15613+
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.1.6.tgz#02f8ac202b6dad2c0dd5e0913745b47a37998274"
15614+
integrity sha512-zaWCozRZ6DLEWAWFrVDz1H6FVXzUSfTy5FUMWsQlU8Ym5JP9eO4xkTIROFCQvhQf61z6O/G6ugw3SgAnvvm+HA==
1559715615

1559815616
typescript@~4.1.3:
1559915617
version "4.1.6"

0 commit comments

Comments
 (0)