Merge pull request #3032 from finos/datagrid-style-nulls

Expose `null` cell style for `perspective-viewer-datagrid`

Author: texodus

.github/workflows/build.yaml

@@ -164,7 +164,6 @@ jobs:
                   path: |
                       rust/perspective-js/dist/
                       rust/perspective-viewer/dist
-                      packages/perspective-jupyterlab/dist/
                       packages/perspective-viewer-d3fc/dist
                       packages/perspective-viewer-datagrid/dist
                       packages/perspective-viewer-openlayers/dist
@@ -526,6 +525,7 @@ jobs:
               uses: ./.github/actions/install-deps
               with:
                   rust: "false"
+                  playwright: "true"
                   cpp: "false"
                   skip_cache: ${{ steps.config-step.outputs.SKIP_CACHE }}
 
@@ -576,6 +576,13 @@ jobs:
               if: ${{ runner.os == 'Linux' }}
 
             - name: Run Jupyter Tests
+              if: ${{ runner.os == 'Linux' }}
+              run: pnpm run test
+              env:
+                  PACKAGE: "perspective-jupyterlab"
+                  # PSP_USE_CCACHE: 1
+
+            - name: Run Jupyter Integration Tests
               if: ${{ false }}
               # if: ${{ runner.os == 'Linux' }}
               run: |

packages/perspective-viewer-datagrid/src/js/data_listener/format_cell.js

@@ -35,7 +35,7 @@ export function format_cell(
     use_table_schema = false
 ) {
     if (val === null) {
-        return "-";
+        return null;
     }
 
     const type =

packages/perspective-viewer-datagrid/src/js/event_handlers/click/edit_click.js

@@ -45,7 +45,7 @@ export function clickListener(table, _viewer, event) {
     if (typeof meta?.x !== "undefined") {
         const is_editable2 = this._is_editable[meta.x];
         const is_bool = this.get_psp_type(meta) === "boolean";
-        const is_null = event.target.textContent === "-";
+        const is_null = event.target.classList.contains("psp-null");
         if (is_editable2 && is_bool && !is_null) {
             write_cell(table, this, event.target);
         }

packages/perspective-viewer-datagrid/src/js/style_handlers/table_cell/index.js

@@ -95,6 +95,7 @@ export function table_cell_style_listener(regularTable, viewer) {
                 delete td.dataset.x;
             }
 
+            td.classList.toggle("psp-null", metadata.value === null);
             td.classList.toggle("psp-align-right", !is_th && is_numeric);
             td.classList.toggle("psp-align-left", is_th || !is_numeric);
             td.classList.toggle(

packages/perspective-viewer-datagrid/src/less/pro.less

@@ -188,4 +188,9 @@ regular-table {
     a:visited {
         color: var(--active--color);
     }
+
+    td.psp-null:after,
+    th.psp-null:after {
+        content: var(--null--content, "-");
+    }
 }

tools/perspective-scripts/test_js.mjs

@@ -39,7 +39,7 @@ const IS_PLAYWRIGHT = get_scope().reduce(
             "perspective-viewer-openlayers",
             "perspective-viewer-workspace",
             "perspective-workspace",
-            "perspective-jupyter",
+            "perspective-jupyterlab",
         ].includes(pkg),
     false
 );