From 151ff57acfe9629c00ad4a42de65e930c1d19570 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Jare=C5=A1?= Date: Sun, 30 Aug 2026 10:33:48 +0200 Subject: [PATCH] Run CI on a pull request whatever branch it targets MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both workflows filtered pull_request by base branch, ci.yml to main, rel/* and dev/*, and code-analysis.yml to main. A pull request opened against anything else matched neither, so it got no checks at all. A pull request with no checks does not look broken, it looks fine, which is worse than a red one. That is what happened to #3015. It was stacked on the 6.2.0-alpha1 release branch so it could add its entry to docs/NEXT-RELEASE.md, and it sat there with zero signal until the workflows were dispatched by hand against the branch. Dropping the filter is better than adding another pattern to the list. A pattern only helps when you remember to name the branch correctly, and forgetting is silent, which is the same trap again. Any pull request is worth testing, whatever it targets. push keeps its filter. That one is about which branches are worth building on their own, and main plus rel/* is still the right answer there. 🤖 --- .github/workflows/ci.yml | 6 +++++- .github/workflows/code-analysis.yml | 3 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b2c538a9f..9db53eb7e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,8 +30,12 @@ on: - 'docs/**' - 'images/**' - '**/*.md' + # No branches filter here on purpose. Filtering pull_request by base branch means a pull + # request opened against anything else gets no checks at all, and a pull request with no + # checks reads as fine rather than as red. That happened to #3015, which was stacked on the + # 6.2.0-alpha1 release branch and sat there with zero signal until the workflows were + # dispatched by hand. Any pull request is worth testing, whatever it targets. pull_request: - branches: [main, 'rel/*', 'dev/*'] paths-ignore: - '.devcontainer/**' - '.vscode/**' diff --git a/.github/workflows/code-analysis.yml b/.github/workflows/code-analysis.yml index 367f03176..157c9e5b2 100644 --- a/.github/workflows/code-analysis.yml +++ b/.github/workflows/code-analysis.yml @@ -3,8 +3,9 @@ name: Code analysis on: push: branches: [main] + # No branches filter, same reason as ci.yml: a pull request stacked on another branch would + # otherwise get no analysis and look like it passed. pull_request: - branches: [main] workflow_dispatch: jobs: