refactor: test result

Author: nunomaduro

src/Compiler.php

@@ -9,7 +9,7 @@
 /**
  * @internal
  */
-final class Compiler
+final readonly class Compiler
 {
     /**
      * The path to the tests.
@@ -20,7 +20,7 @@ final class Compiler
      * @param  array<int, Operation>  $operations
      */
     public function __construct(
-        private readonly array $operations
+        private array $operations
     ) {
         //
     }
@@ -43,16 +43,6 @@ public function compile(): void
 
             test('runtime', async ({ page }) => {
             $content
-
-                const response = await page.reload();
-                test.info().annotations.push({
-                    type: '_response',
-                    description: JSON.stringify({
-                        headers: response.headers(),
-                        status: response.status(),
-                        url: response.url(),
-                    })
-                });
             });
             JS,
         );

src/PendingTest.php

@@ -4,9 +4,8 @@
 
 namespace Pest\Browser;
 
-use Pest\Browser\ValueObjects\TestResult;
-use Pest\Browser\ValueObjects\TestResultResponse;
 use Pest\Browser\Contracts\Operation;
+use Pest\Browser\ValueObjects\TestResult;
 
 /**
  * @internal
@@ -68,18 +67,10 @@ public function assertUrlIs(string $url): self
         return $this;
     }
 
-    /**
-     * Build and return the final response the test received.
-     */
-    public function response(): TestResultResponse
-    {
-        return $this->build()->response();
-    }
-
     /**
      * Compile the JavaScript test file.
      */
-    public function build(): void
+    public function compile(): TestResult
     {
         $compiler = new Compiler($this->operations);
 

src/Support/Str.php

@@ -18,16 +18,10 @@ public static function isRegex(string $target): bool
             return false;
         }
 
-        // If the first and last characters are not the same, it's not a regex
         if (($delimiter = mb_substr($target, 0, 1)) !== mb_substr($target, -1, 1)) {
             return false;
         }
 
-        // If the delimiter is alphanumeric, it's not a regex
-        if (! preg_match('/[^a-zA-Z0-9]/', $delimiter)) {
-            return false;
-        }
-
-        return true;
+        return preg_match('/[^a-zA-Z0-9]/', $delimiter) !== false;
     }
 }

src/ValueObjects/TestResult.php

@@ -14,7 +14,6 @@
      */
     public function __construct(
         private bool $ok,
-        private TestResultResponse $response,
     ) {
         //
     }
@@ -26,12 +25,4 @@ public function ok(): bool
     {
         return $this->ok;
     }
-
-    /**
-     * Get the final response from the test result.
-     */
-    public function response(): TestResultResponse
-    {
-        return $this->response;
-    }
 }

src/ValueObjects/TestResultResponse.php

@@ -5,7 +5,6 @@
 namespace Pest\Browser;
 
 use Pest\Browser\ValueObjects\TestResult;
-use Pest\Browser\ValueObjects\TestResultResponse;
 use Pest\Support\Arr;
 use Symfony\Component\Process\Process;
 
@@ -25,12 +24,11 @@ public function run(): TestResult
 
         $output = $process->getOutput();
 
-        // @phpstan-ignore-next-line
+        /** @var array<int, mixed> $outputAsArray */
         $outputAsArray = json_decode($output, true);
 
-        $ok = Arr::get($outputAsArray, 'suites.0.specs.0.ok');
-        $annotations = Arr::get($outputAsArray, 'suites.0.specs.0.tests.0.annotations');
+        $ok = (bool) Arr::get($outputAsArray, 'suites.0.specs.0.ok');
 
-        return new TestResult($ok, new TestResultResponse($annotations));
+        return new TestResult($ok);
     }
 }

src/Worker.php

@@ -22,11 +22,4 @@
     visit('https://laravel.com')
         ->clickLink('Get Started')
         ->assertUrlIs('https://laravel.com/docs/11.x');
-
-    // -- or --
-
-    $browser = visit('https://laravel.com')
-        ->clickLink('Get Started');
-
-    expect($browser->response()->url())->toBe('https://laravel.com/docs/11.x');
 });