Skip to content

Commit c22afe1

Browse files
authored
Apply fixes from StyleCI (#76)
[ci skip] [skip ci]
1 parent 5e18eb0 commit c22afe1

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

app/Http/Controllers/StudentController.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public function index(Request $request)
3131
$query->withTrashed();
3232
},
3333
'dos' => function ($query) {
34-
$query;
3534
},
3635
'enrolmentStatus' => function ($query) {
3736
$query->withTrashed();

app/Notifications/StartTodayReminder.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ public function toMail($notifiable)
7474
if (config('app.all_notifications_email')) {
7575
$msg->bcc(config('app.all_notifications_email'));
7676
}
77+
7778
return $msg;
7879
}
7980
}

app/Notifications/StudentMilestoneApprovalAlert.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function toMail($notifiable)
7373
}
7474
if ($this->approval->reason) {
7575
$lineTwo .= sprintf(
76-
'The following additional feedback was provided: %s. ',
76+
'The following additional feedback was provided: %s. ',
7777
str_finish($this->approval->reason, '.')
7878
);
7979
}

app/Notifications/SupervisorMilestoneApprovalAlert.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,17 +64,17 @@ public function toMail($notifiable)
6464
if (! $this->approval->approved) { // if rejected
6565
$lineOne .= ' They will be required to amend the documentation and submit an updated version.';
6666
if ($this->approval->reason) {
67-
$lineTwo .= sprintf("The following feedback was provided: %s. ", str_finish($this->approval->reason, '.'));
67+
$lineTwo .= sprintf('The following feedback was provided: %s. ', str_finish($this->approval->reason, '.'));
6868
}
6969
$lineTwo .= sprintf(
70-
"Please ensure %s understands the alterations that must be made. For further clarification, please liaise with the PGR admin team.", $this->student->first_name);
70+
'Please ensure %s understands the alterations that must be made. For further clarification, please liaise with the PGR admin team.', $this->student->first_name);
7171
}
7272

7373
return (new MailMessage)
7474
->line($lineOne)
7575
->line($lineTwo)
7676
->action('View Milestone', $url)
7777
->line('Thanks!')
78-
->subject(sprintf("Milestone %s: %s [%s]", $this->student->name, $this->milestone->name, strtoupper($status)));
78+
->subject(sprintf('Milestone %s: %s [%s]', $this->student->name, $this->milestone->name, strtoupper($status)));
7979
}
8080
}

0 commit comments

Comments
 (0)