Commit 1463b9b
authored
[SLO] Fix APM embeddable ids (elastic#264750)
## Summary
Closes elastic#264008
As part of the dashboards as code effort, elastic#254079 introduced a change by
which embeddable ids were changed. While most usages were properly
updated, a couple of hardcoded string references in the SLO plugin were
left unchanged. This is leading to issues where the APM embeddables in
the alert details page are failing to be displayed because the code is
unable to find the appropiate embeddable factory when searching by it's
old id.
In order to prevent issues like this in the future, I plan to do a
follow up PR providing a proper fix to this issue in a way that allows
the SLO plugin to consume the embeddable id constants defined in APM
instead of having to relay on redefining the strings values in both
plugins, which can lead to inconsistencies as this one. But, given the
timing with the 9.4 BC I've decided to go first for this quick-and-easy
approach of just changing the strings in the SLO plugin as well. While
this is not ideal code-wise it will allow us to have a low-risk fix in
time to be backported to 9.4 so we don't ship this view in a broken
state.1 parent c5cbc5f commit 1463b9b
2 files changed
Lines changed: 9 additions & 11 deletions
File tree
- x-pack/solutions/observability/plugins/slo/public/components/alert_details/components/custom_panels/apm
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
26 | 24 | | |
27 | 25 | | |
28 | 26 | | |
| |||
0 commit comments