Commit 156f304
Fix
Adds `aria-hidden={true}` to 21 decorative `EuiIcon` instances across 14
files owned by `@elastic/kibana-data-discovery`. All icons are purely
decorative—adjacent text already conveys the same information to
assistive technology.
### Changes
- **External link indicators** (`type="link"`) inside `<EuiLink>` with
visible text — `date.tsx`, `date_nanos.tsx`, `histogram.tsx`,
`number.tsx`, `scripting_syntax.tsx`
- **Chevron/arrow icons** inside buttons/links with text labels —
`view_details_popover.tsx`, `delete_data_view_flyout_content.tsx`
- **Status icons** (warning, error) next to descriptive text —
`badge.tsx`, `field_editor.tsx`, `error_callout.tsx`,
`table_cell_value.tsx`
- **Card/decorative icons** where card title provides meaning —
`empty_index_list_prompt.tsx`, `index_header.tsx`
- **Drag handle** (visual-only affordance) — `field_item_button.tsx`
```tsx
// Before
<EuiIcon type="link" />
// After
<EuiIcon type="link" aria-hidden={true} />
```
Closes elastic#269033
> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `ci-stats.kibana.dev`
> - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node
/opt/hostedtoolcache/node/24.14.1/x64/bin/node
scripts/yarn_install_scripts.js run ldd 0.8.2` (dns block)
> - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node
/opt/hostedtoolcache/node/24.14.1/x64/bin/node scripts/kbn bootstrap`
(dns block)
> - `clients3.google.com`
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack ldd 0.8.2` (dns block)
> - `detectportal.firefox.com`
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack ldd 0.8.2` (dns block)
> - `google.com`
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack ldd 0.8.2` (dns block)
> - `googlechromelabs.github.io`
> - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node
/opt/hostedtoolcache/node/24.14.1/x64/bin/node install.js` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/elastic/kibana/settings/copilot/coding_agent)
(admins only)
>
> </details>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>@elastic/eui/icon-accessibility-rules lint violations across data-discovery files (elastic#269040)1 parent a075620 commit 156f304
20 files changed
Lines changed: 27 additions & 19 deletions
File tree
- src/platform
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| |||
0 commit comments