Skip to content

Commit 156f304

Browse files
Copilotalexwizp
andauthored
Fix @elastic/eui/icon-accessibility-rules lint violations across data-discovery files (elastic#269040)
Adds `aria-hidden={true}` to 21 decorative `EuiIcon` instances across 14 files owned by `@elastic/kibana-data-discovery`. All icons are purely decorative—adjacent text already conveys the same information to assistive technology. ### Changes - **External link indicators** (`type="link"`) inside `<EuiLink>` with visible text — `date.tsx`, `date_nanos.tsx`, `histogram.tsx`, `number.tsx`, `scripting_syntax.tsx` - **Chevron/arrow icons** inside buttons/links with text labels — `view_details_popover.tsx`, `delete_data_view_flyout_content.tsx` - **Status icons** (warning, error) next to descriptive text — `badge.tsx`, `field_editor.tsx`, `error_callout.tsx`, `table_cell_value.tsx` - **Card/decorative icons** where card title provides meaning — `empty_index_list_prompt.tsx`, `index_header.tsx` - **Drag handle** (visual-only affordance) — `field_item_button.tsx` ```tsx // Before <EuiIcon type="link" /> // After <EuiIcon type="link" aria-hidden={true} /> ``` Closes elastic#269033 > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `ci-stats.kibana.dev` > - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2` (dns block) > - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node scripts/kbn bootstrap` (dns block) > - `clients3.google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2` (dns block) > - `detectportal.firefox.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2` (dns block) > - `google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2` (dns block) > - `googlechromelabs.github.io` > - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node install.js` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/elastic/kibana/settings/copilot/coding_agent) (admins only) > > </details> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
1 parent a075620 commit 156f304

20 files changed

Lines changed: 27 additions & 19 deletions

File tree

src/platform/packages/shared/kbn-search-response-warnings/src/components/search_response_warnings/badge.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ export const SearchResponseWarningsBadge = (props: Props) => {
5757
>
5858
<EuiIcon
5959
type="warning"
60+
aria-hidden={true}
6061
css={css`
6162
margin-left: ${euiTheme.size.xxs};
6263
`}

src/platform/packages/shared/kbn-search-response-warnings/src/components/search_response_warnings/view_details_popover.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export const ViewDetailsPopover = (props: Props) => {
8282
data-test-subj="searchResponseWarningsViewDetails"
8383
>
8484
<>
85-
{viewDetailsLabel} <EuiIcon type="chevronSingleRight" size="s" />
85+
{viewDetailsLabel} <EuiIcon type="chevronSingleRight" size="s" aria-hidden={true} />
8686
</>
8787
</EuiLink>
8888
) : (

src/platform/packages/shared/kbn-unified-field-list/src/components/field_item_button/field_item_button.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { FieldIcon, getFieldIconProps, getFieldSearchMatchingHighlight } from '@
2727
import { useMemoCss } from '@kbn/css-utils/public/use_memo_css';
2828
import { type FieldListItem, type GetCustomFieldType } from '../../types';
2929

30-
const DRAG_ICON = <EuiIcon type="drag" size="m" />;
30+
const DRAG_ICON = <EuiIcon type="drag" size="m" aria-hidden={true} />;
3131

3232
/**
3333
* Props of FieldItemButton component

src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/bytes/__snapshots__/bytes.test.tsx.snap

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/date/__snapshots__/date.test.tsx.snap

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/date/date.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export class DateFormatEditor extends DefaultFormatEditor<DateFormatEditorFormat
6060
defaultMessage="Documentation"
6161
/>
6262
&nbsp;
63-
<EuiIcon type="link" />
63+
<EuiIcon type="link" aria-hidden={true} />
6464
</EuiLink>
6565
</span>
6666
}

src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/date_nanos/__snapshots__/date_nanos.test.tsx.snap

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/date_nanos/date_nanos.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export class DateNanosFormatEditor extends DefaultFormatEditor<DateNanosFormatEd
5959
defaultMessage="Documentation"
6060
/>
6161
&nbsp;
62-
<EuiIcon type="link" />
62+
<EuiIcon type="link" aria-hidden={true} />
6363
</EuiLink>
6464
</span>
6565
}

src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/histogram/__snapshots__/histogram.test.tsx.snap

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/histogram/histogram.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export class HistogramFormatEditor extends DefaultFormatEditor<HistogramFormatEd
8484
defaultMessage="Documentation"
8585
/>
8686
&nbsp;
87-
<EuiIcon type="link" />
87+
<EuiIcon type="link" aria-hidden={true} />
8888
</EuiLink>
8989
</span>
9090
}

0 commit comments

Comments
 (0)