[Unified Rules] Update "Go to rules" link in Saved Object import workflow (elastic#250220)

miguelmartin-elastic · kibanamachine · web-flow · commit 8661bdedb219 · 2026-01-28T11:46:27.000Z
closes elastic#239614 ## Summary Make the "Go to rules" button in the Saved Object import flow redirect the user to the unified rules page (`/app/rules`) if the feature flag `xpack.trigger_actions_ui.enableExperimental.unifiedRulesPage` is enabled. Since... 1. This feature flag lives within the configuration of the `triggersActionsUi` plugin 2. The `triggersActionsUi` plugin depends on the `alerting` plugin 3. The `actionPath` is initialized in the `alerting` plugin server-side code ... we can't check if the FF is enabled directly on the `alerting` server-side code. For this reason, I've moved the logic to determine the link to the frontend code, in which we use `kibana.services.application.isAppRegistered` to check if the `rules` app is registered as an indirect way of knowing if the feature flag is enabled. Similar to the work done [here](https://github.com/elastic/kibana/pull/249750/files). Once the migration to the new unified rules page is complete we should remove/revert these changes and modify the link directly in `x-pack/platform/plugins/shared/alerting/server/saved_objects/get_import_warnings.ts` ![demoSavedObjectImport](https://github.com/user-attachments/assets/cb4d6474-0eae-41ba-94cb-02344192a6a7) ## Testing To test this change: ### Functional 1. Enable the feature flag: `xpack.trigger_actions_ui.enableExperimental: ['unifiedRulesPage']` 2. Navigate to the Import Saved Objects page (http://localhost:5601/app/management/kibana/objects) 3. Start importing a saved object with rules 4. Click on "Create new objects with random IDs" 5. Select a file to import 6. Click on "Import" 7. Verify that a warning is shown and that clicking on "Go to rules" redirects you to the new unified rules page ### Regression 1. Disable the feature flag 2. Repeat Functional steps from 2 to 6 3. Verify that a warning is shown and that clicking on "Go to rules" redirects you to the legacy Management rules page (http://localhost:5601/app/management/insightsAndAlerting/triggersActions/rules) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
diff --git a/src/platform/plugins/shared/saved_objects_management/moon.yml b/src/platform/plugins/shared/saved_objects_management/moon.yml
@@ -43,6 +43,7 @@ dependsOn:
   - '@kbn/react-kibana-context-render'
   - '@kbn/shared-ux-table-persist'
   - '@kbn/css-utils'
+  - '@kbn/content-management-plugin'
 tags:
   - plugin
   - prod
diff --git a/src/platform/plugins/shared/saved_objects_management/public/management_section/mount_section.tsx b/src/platform/plugins/shared/saved_objects_management/public/management_section/mount_section.tsx
@@ -16,6 +16,7 @@ import { EuiLoadingSpinner } from '@elastic/eui';
 import type { CoreSetup } from '@kbn/core/public';
 import type { ManagementAppMountParams } from '@kbn/management-plugin/public';
 import { KibanaRenderContextProvider } from '@kbn/react-kibana-context-render';
+import { createKibanaReactContext } from '@kbn/kibana-react-plugin/public';
 import type { SavedObjectManagementTypeInfo } from '../../common/types';
 import type { StartDependencies, SavedObjectsManagementPluginStart } from '../plugin';
 import { getAllowedTypes } from '../lib';
@@ -66,40 +67,44 @@ export const mountManagementSection = async ({
     return children! as React.ReactElement;
   };
 
+  const { Provider: KibanaReactContextProvider } = createKibanaReactContext(coreStart);
+
   ReactDOM.render(
     <KibanaRenderContextProvider {...coreStart}>
-      <Router history={history}>
-        <Routes>
-          <Route path={'/:type/:id'} exact={true}>
-            <RedirectToHomeIfUnauthorized>
-              <Suspense fallback={<EuiLoadingSpinner />}>
-                <SavedObjectsEditionPage
-                  coreStart={coreStart}
-                  setBreadcrumbs={setBreadcrumbs}
-                  history={history}
-                />
-              </Suspense>
-            </RedirectToHomeIfUnauthorized>
-          </Route>
-          <Route path={'/'} exact={false}>
-            <RedirectToHomeIfUnauthorized>
-              <Suspense fallback={<EuiLoadingSpinner />}>
-                <SavedObjectsTablePage
-                  coreStart={coreStart}
-                  taggingApi={savedObjectsTaggingOss?.getTaggingApi()}
-                  spacesApi={spacesApi}
-                  dataStart={data}
-                  dataViewsApi={dataViews}
-                  actionRegistry={getActionServiceStart()}
-                  columnRegistry={getColumnServiceStart()}
-                  allowedTypes={allowedObjectTypes}
-                  setBreadcrumbs={setBreadcrumbs}
-                />
-              </Suspense>
-            </RedirectToHomeIfUnauthorized>
-          </Route>
-        </Routes>
-      </Router>
+      <KibanaReactContextProvider>
+        <Router history={history}>
+          <Routes>
+            <Route path={'/:type/:id'} exact={true}>
+              <RedirectToHomeIfUnauthorized>
+                <Suspense fallback={<EuiLoadingSpinner />}>
+                  <SavedObjectsEditionPage
+                    coreStart={coreStart}
+                    setBreadcrumbs={setBreadcrumbs}
+                    history={history}
+                  />
+                </Suspense>
+              </RedirectToHomeIfUnauthorized>
+            </Route>
+            <Route path={'/'} exact={false}>
+              <RedirectToHomeIfUnauthorized>
+                <Suspense fallback={<EuiLoadingSpinner />}>
+                  <SavedObjectsTablePage
+                    coreStart={coreStart}
+                    taggingApi={savedObjectsTaggingOss?.getTaggingApi()}
+                    spacesApi={spacesApi}
+                    dataStart={data}
+                    dataViewsApi={dataViews}
+                    actionRegistry={getActionServiceStart()}
+                    columnRegistry={getColumnServiceStart()}
+                    allowedTypes={allowedObjectTypes}
+                    setBreadcrumbs={setBreadcrumbs}
+                  />
+                </Suspense>
+              </RedirectToHomeIfUnauthorized>
+            </Route>
+          </Routes>
+        </Router>
+      </KibanaReactContextProvider>
     </KibanaRenderContextProvider>,
     element
   );
diff --git a/src/platform/plugins/shared/saved_objects_management/public/management_section/objects_table/components/import_summary.test.tsx b/src/platform/plugins/shared/saved_objects_management/public/management_section/objects_table/components/import_summary.test.tsx
@@ -11,12 +11,15 @@ import React from 'react';
 import type { ReactWrapper } from 'enzyme';
 import { mountWithI18nProvider } from '@kbn/test-jest-helpers';
 import { httpServiceMock } from '@kbn/core/public/mocks';
+import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
+import { coreMock } from '@kbn/core/public/mocks';
 import type { ImportSummaryProps } from './import_summary';
 import { ImportSummary } from './import_summary';
 import type { FailedImport } from '../../../lib';
 
 describe('ImportSummary', () => {
   let basePath: ReturnType<typeof httpServiceMock.createBasePath>;
+  type PrependType = jest.MockInstance<string, [url: string], unknown> & ((url: string) => string);
 
   const getProps = (parts: Partial<ImportSummaryProps>): ImportSummaryProps => ({
     basePath,
@@ -175,4 +178,61 @@ describe('ImportSummary', () => {
 
     expect(findWarnings(wrapper)).toHaveLength(2);
   });
+
+  it('should use /app/rules actionPath when rules app is registered', async () => {
+    const coreStart = coreMock.createStart();
+    coreStart.application.isAppRegistered = jest.fn().mockReturnValue(true);
+    basePath.prepend = ((path: string) => path) as PrependType;
+
+    const props = getProps({
+      successfulImports: [successNew],
+      importWarnings: [
+        {
+          type: 'action_required',
+          message: 'Rules need to be enabled',
+          actionPath: '/app/management/insightsAndAlerting/triggersActions/rules',
+        },
+      ],
+    });
+
+    const wrapper = mountWithI18nProvider(
+      <KibanaContextProvider services={coreStart}>
+        <ImportSummary {...props} />
+      </KibanaContextProvider>
+    );
+
+    const button = wrapper.find('EuiButton[data-test-subj="warningActionButton"]');
+    expect(button).toHaveLength(1);
+    expect(button.prop('href')).toBe('/app/rules');
+    expect(coreStart.application.isAppRegistered).toHaveBeenCalledWith('rules');
+  });
+
+  it('should use original actionPath when rules app is not registered', async () => {
+    const coreStart = coreMock.createStart();
+    coreStart.application.isAppRegistered = jest.fn().mockReturnValue(false);
+    basePath.prepend = ((path: string) => path) as PrependType;
+
+    const originalActionPath = '/app/management/insightsAndAlerting/triggersActions/rules';
+    const props = getProps({
+      successfulImports: [successNew],
+      importWarnings: [
+        {
+          type: 'action_required',
+          message: 'Rules need to be enabled',
+          actionPath: originalActionPath,
+        },
+      ],
+    });
+
+    const wrapper = mountWithI18nProvider(
+      <KibanaContextProvider services={coreStart}>
+        <ImportSummary {...props} />
+      </KibanaContextProvider>
+    );
+
+    const button = wrapper.find('EuiButton[data-test-subj="warningActionButton"]');
+    expect(button).toHaveLength(1);
+    expect(button.prop('href')).toBe(originalActionPath);
+    expect(coreStart.application.isAppRegistered).toHaveBeenCalledWith('rules');
+  });
 });
diff --git a/src/platform/plugins/shared/saved_objects_management/public/management_section/objects_table/components/import_summary.tsx b/src/platform/plugins/shared/saved_objects_management/public/management_section/objects_table/components/import_summary.tsx
@@ -28,9 +28,12 @@ import type {
   SavedObjectsImportSuccess,
   SavedObjectsImportWarning,
   IBasePath,
+  CoreStart,
 } from '@kbn/core/public';
 import { useMemoCss } from '@kbn/css-utils/public/use_memo_css';
 import { css } from '@emotion/react';
+import { useKibana } from '@kbn/kibana-react-plugin/public';
+import type { StartDependencies } from '@kbn/content-management-plugin/public/types';
 import type { SavedObjectManagementTypeInfo } from '../../../../common/types';
 import type { FailedImport } from '../../../lib';
 import { getDefaultTitle, getSavedObjectLabel } from '../../../lib';
@@ -202,9 +205,26 @@ const ImportWarnings: FC<{ warnings: SavedObjectsImportWarning[]; basePath: IBas
 };
 
 const ImportWarning: FC<{ warning: SavedObjectsImportWarning; basePath: IBasePath }> = ({
-  warning,
+  warning: providedWarning,
   basePath,
 }) => {
+  const kibana = useKibana<CoreStart & StartDependencies>();
+  const isUnifiedRulesPageEnabled = useMemo(
+    () => kibana.services.application?.isAppRegistered?.('rules') ?? false,
+    [kibana.services.application]
+  );
+
+  const warning = useMemo(
+    () =>
+      isUnifiedRulesPageEnabled && 'actionPath' in providedWarning
+        ? {
+            ...providedWarning,
+            actionPath: '/app/rules',
+          }
+        : providedWarning,
+    [isUnifiedRulesPageEnabled, providedWarning]
+  );
+
   const warningContent = useMemo(() => {
     if (warning.type === 'action_required') {
       return (
@@ -213,6 +233,7 @@ const ImportWarning: FC<{ warning: SavedObjectsImportWarning; basePath: IBasePat
             <EuiButton
               size="s"
               color="warning"
+              data-test-subj="warningActionButton"
               href={basePath.prepend(warning.actionPath)}
               target="_blank"
             >
diff --git a/src/platform/plugins/shared/saved_objects_management/tsconfig.json b/src/platform/plugins/shared/saved_objects_management/tsconfig.json
@@ -34,6 +34,7 @@
     "@kbn/react-kibana-context-render",
     "@kbn/shared-ux-table-persist",
     "@kbn/css-utils",
+    "@kbn/content-management-plugin",
   ],
   "exclude": [
     "target/**/*",
