[ES|QL] Create dataviews without asking for fields wherever is not required (elastic#240197)

## Summary

Fetching fields can be expensive. I have upgraded the esql adhoc
dataview helper to have a skip fields flag. I have also looked into the
codebase and I apply it wherever is not required.

This will give a performance boost to the consumers especially for
sources with many fields.

Note: I have tested the applications and I don't see any regressions but
please test carefully too!

Author: stratoula

src/platform/packages/shared/kbn-esql-utils/src/utils/get_esql_adhoc_dataview.ts

@@ -36,6 +36,7 @@ export async function getESQLAdHocDataview(
   options?: {
     allowNoIndex?: boolean;
     createNewInstanceEvenIfCachedOneAvailable?: boolean;
+    skipFetchFields?: boolean;
   }
 ) {
   const timeField = getTimeFieldFromESQLQuery(query);
@@ -46,13 +47,18 @@ export async function getESQLAdHocDataview(
     // overwise it might return a cached data view with a different time field
     dataViewsService.clearInstanceCache(dataViewId);
   }
+  const skipFetchFields = options?.skipFetchFields ?? false;
 
-  const dataView = await dataViewsService.create({
-    title: indexPattern,
-    type: ESQL_TYPE,
-    id: dataViewId,
-    allowNoIndex: options?.allowNoIndex,
-  });
+  const dataView = await dataViewsService.create(
+    {
+      title: indexPattern,
+      type: ESQL_TYPE,
+      id: dataViewId,
+      allowNoIndex: options?.allowNoIndex,
+    },
+    // important to skip if you just need the dataview without the fields for performance reasons
+    skipFetchFields
+  );
 
   dataView.timeFieldName = timeField;
 

x-pack/platform/plugins/shared/lens/public/app_plugin/shared/edit_on_the_fly/helpers.ts

@@ -70,7 +70,7 @@ export const getGridAttrs = async (
 
   const dataView = dataViewSpec
     ? await data.dataViews.create(dataViewSpec)
-    : await getESQLAdHocDataview(query.esql, data.dataViews);
+    : await getESQLAdHocDataview(query.esql, data.dataViews, { skipFetchFields: true });
 
   const filter = getDSLFilter(data.query, uiSettings, dataView.timeFieldName);
 

x-pack/platform/plugins/shared/lens/public/datasources/form_based/esql_layer/text_based_languages.tsx

@@ -680,7 +680,9 @@ export function getTextBasedDatasource({
 
       for (const { query } of Object.values(state.layers)) {
         if (query) {
-          const esqlAdhocDataview = await getESQLAdHocDataview(query.esql, dataViewsService);
+          const esqlAdhocDataview = await getESQLAdHocDataview(query.esql, dataViewsService, {
+            skipFetchFields: true,
+          });
           indexPatterns.push(esqlAdhocDataview);
         }
       }

x-pack/platform/plugins/shared/lens/public/datasources/form_based/esql_layer/utils.ts

@@ -97,7 +97,7 @@ export async function getStateFromAggregateQuery(
   let columnsFromQuery: DatatableColumn[] = [];
   let timeFieldName;
   try {
-    const dataView = await getESQLAdHocDataview(query.esql, dataViews);
+    const dataView = await getESQLAdHocDataview(query.esql, dataViews, { skipFetchFields: true });
 
     if (dataView && dataView.id) {
       dataViewId = dataView?.id;

x-pack/platform/plugins/shared/lens/public/lens_suggestions_api/readme.md

@@ -40,7 +40,7 @@ The api returns an array of suggestions.
 
 ```typescript
 const indexName = (await getIndexForESQLQuery({ dataViews })) ?? '*';
-const dataView = await getESQLAdHocDataview(`from ${indexName}`, dataViews);
+const dataView = await getESQLAdHocDataview(`from ${indexName}`, dataViews, { skipFetchFields: true });
 ```
 Optional parameters:
 - `preferredChartType`: Use this if you want the suggestions api to prioritize a specific suggestion type.

x-pack/platform/plugins/shared/onechat/public/application/components/tools/esql/visualize_esql/use_lens_input.ts

@@ -56,7 +56,7 @@ export function useLensInput({
 
   const lensHelpersAsync = useAsync(() => lens.stateHelperApi(), [lens]);
   const dataViewAsync = useAsync(
-    () => getESQLAdHocDataview(esqlQuery, dataViews),
+    () => getESQLAdHocDataview(esqlQuery, dataViews, { skipFetchFields: true }),
     [esqlQuery, dataViews]
   );
 

x-pack/solutions/observability/plugins/observability_ai_assistant_app/public/functions/visualize_esql.tsx

@@ -112,7 +112,7 @@ export function VisualizeESQL({
   }, [lens]);
 
   const dataViewAsync = useAsync(() => {
-    return getESQLAdHocDataview(query, dataViews);
+    return getESQLAdHocDataview(query, dataViews, { skipFetchFields: true });
   }, [query, dataViews]);
 
   const chatFlyoutSecondSlotHandler = useContext(ObservabilityAIAssistantMultipaneFlyoutContext);