Skip to content

Commit 9b70d37

Browse files
[SharedUX] Move Analytics and Kibana NoData pages from private to shared package (elastic#228956)
## Summary This PR moves code for Analytics and Kibana No Data pages that were in private packages to shared. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
1 parent b60c89d commit 9b70d37

65 files changed

Lines changed: 49 additions & 49 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/CODEOWNERS

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -381,12 +381,6 @@ src/platform/packages/private/kbn-transpose-utils @elastic/kibana-visualizations
381381
src/platform/packages/private/kbn-ui-shared-deps-npm @elastic/kibana-operations
382382
src/platform/packages/private/kbn-ui-shared-deps-src @elastic/kibana-operations
383383
src/platform/packages/private/kbn-unsaved-changes-badge @elastic/kibana-data-discovery
384-
src/platform/packages/private/shared-ux/page/analytics_no_data/impl @elastic/appex-sharedux
385-
src/platform/packages/private/shared-ux/page/analytics_no_data/mocks @elastic/appex-sharedux
386-
src/platform/packages/private/shared-ux/page/analytics_no_data/types @elastic/appex-sharedux
387-
src/platform/packages/private/shared-ux/page/kibana_no_data/impl @elastic/appex-sharedux
388-
src/platform/packages/private/shared-ux/page/kibana_no_data/mocks @elastic/appex-sharedux
389-
src/platform/packages/private/shared-ux/page/kibana_no_data/types @elastic/appex-sharedux
390384
src/platform/packages/private/shared-ux/storybook/config @elastic/appex-sharedux
391385
src/platform/packages/shared/chart-expressions-common @elastic/kibana-visualizations
392386
src/platform/packages/shared/cloud @elastic/kibana-core
@@ -643,6 +637,12 @@ src/platform/packages/shared/shared-ux/markdown/impl @elastic/appex-sharedux
643637
src/platform/packages/shared/shared-ux/markdown/mocks @elastic/appex-sharedux
644638
src/platform/packages/shared/shared-ux/markdown/types @elastic/appex-sharedux
645639
src/platform/packages/shared/shared-ux/modal/tabbed @elastic/appex-sharedux
640+
src/platform/packages/shared/shared-ux/page/analytics_no_data/impl @elastic/appex-sharedux
641+
src/platform/packages/shared/shared-ux/page/analytics_no_data/mocks @elastic/appex-sharedux
642+
src/platform/packages/shared/shared-ux/page/analytics_no_data/types @elastic/appex-sharedux
643+
src/platform/packages/shared/shared-ux/page/kibana_no_data/impl @elastic/appex-sharedux
644+
src/platform/packages/shared/shared-ux/page/kibana_no_data/mocks @elastic/appex-sharedux
645+
src/platform/packages/shared/shared-ux/page/kibana_no_data/types @elastic/appex-sharedux
646646
src/platform/packages/shared/shared-ux/page/kibana_template/impl @elastic/appex-sharedux
647647
src/platform/packages/shared/shared-ux/page/kibana_template/mocks @elastic/appex-sharedux
648648
src/platform/packages/shared/shared-ux/page/kibana_template/types @elastic/appex-sharedux
@@ -674,7 +674,6 @@ src/platform/plugins/private/kibana_overview @elastic/appex-sharedux
674674
src/platform/plugins/private/kibana_usage_collection @elastic/kibana-core
675675
src/platform/plugins/private/links @elastic/kibana-presentation
676676
src/platform/plugins/private/maps_ems @elastic/kibana-presentation
677-
src/platform/plugins/private/no_data_page @elastic/appex-sharedux
678677
src/platform/plugins/private/presentation_panel @elastic/kibana-presentation
679678
src/platform/plugins/private/url_forwarding @elastic/kibana-visualizations
680679
src/platform/plugins/private/vis_default_editor @elastic/kibana-visualizations
@@ -726,6 +725,7 @@ src/platform/plugins/shared/kibana_utils @elastic/appex-sharedux
726725
src/platform/plugins/shared/management @elastic/kibana-management
727726
src/platform/plugins/shared/navigation @elastic/appex-sharedux
728727
src/platform/plugins/shared/newsfeed @elastic/kibana-core
728+
src/platform/plugins/shared/no_data_page @elastic/appex-sharedux
729729
src/platform/plugins/shared/presentation_util @elastic/kibana-presentation
730730
src/platform/plugins/shared/saved_objects @elastic/appex-sharedux
731731
src/platform/plugins/shared/saved_objects_finder @elastic/kibana-data-discovery

docs/extend/plugin-list.md

Lines changed: 1 addition & 1 deletion

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,7 @@
723723
"@kbn/navigation-plugin": "link:src/platform/plugins/shared/navigation",
724724
"@kbn/newsfeed-plugin": "link:src/platform/plugins/shared/newsfeed",
725725
"@kbn/newsfeed-test-plugin": "link:src/platform/test/common/plugins/newsfeed",
726-
"@kbn/no-data-page-plugin": "link:src/platform/plugins/private/no_data_page",
726+
"@kbn/no-data-page-plugin": "link:src/platform/plugins/shared/no_data_page",
727727
"@kbn/node-libs-browser-webpack-plugin": "link:src/platform/packages/private/kbn-node-libs-browser-webpack-plugin",
728728
"@kbn/notifications-plugin": "link:x-pack/platform/plugins/shared/notifications",
729729
"@kbn/object-utils": "link:src/platform/packages/shared/kbn-object-utils",
@@ -952,10 +952,10 @@
952952
"@kbn/shared-ux-link-redirect-app-types": "link:src/platform/packages/shared/shared-ux/link/redirect_app/types",
953953
"@kbn/shared-ux-markdown": "link:src/platform/packages/shared/shared-ux/markdown/impl",
954954
"@kbn/shared-ux-markdown-types": "link:src/platform/packages/shared/shared-ux/markdown/types",
955-
"@kbn/shared-ux-page-analytics-no-data": "link:src/platform/packages/private/shared-ux/page/analytics_no_data/impl",
956-
"@kbn/shared-ux-page-analytics-no-data-types": "link:src/platform/packages/private/shared-ux/page/analytics_no_data/types",
957-
"@kbn/shared-ux-page-kibana-no-data": "link:src/platform/packages/private/shared-ux/page/kibana_no_data/impl",
958-
"@kbn/shared-ux-page-kibana-no-data-types": "link:src/platform/packages/private/shared-ux/page/kibana_no_data/types",
955+
"@kbn/shared-ux-page-analytics-no-data": "link:src/platform/packages/shared/shared-ux/page/analytics_no_data/impl",
956+
"@kbn/shared-ux-page-analytics-no-data-types": "link:src/platform/packages/shared/shared-ux/page/analytics_no_data/types",
957+
"@kbn/shared-ux-page-kibana-no-data": "link:src/platform/packages/shared/shared-ux/page/kibana_no_data/impl",
958+
"@kbn/shared-ux-page-kibana-no-data-types": "link:src/platform/packages/shared/shared-ux/page/kibana_no_data/types",
959959
"@kbn/shared-ux-page-kibana-template": "link:src/platform/packages/shared/shared-ux/page/kibana_template/impl",
960960
"@kbn/shared-ux-page-kibana-template-types": "link:src/platform/packages/shared/shared-ux/page/kibana_template/types",
961961
"@kbn/shared-ux-page-no-data": "link:src/platform/packages/shared/shared-ux/page/no_data/impl",
@@ -1603,8 +1603,8 @@
16031603
"@kbn/shared-ux-file-mocks": "link:src/platform/packages/shared/shared-ux/file/mocks",
16041604
"@kbn/shared-ux-link-redirect-app-mocks": "link:src/platform/packages/shared/shared-ux/link/redirect_app/mocks",
16051605
"@kbn/shared-ux-markdown-mocks": "link:src/platform/packages/shared/shared-ux/markdown/mocks",
1606-
"@kbn/shared-ux-page-analytics-no-data-mocks": "link:src/platform/packages/private/shared-ux/page/analytics_no_data/mocks",
1607-
"@kbn/shared-ux-page-kibana-no-data-mocks": "link:src/platform/packages/private/shared-ux/page/kibana_no_data/mocks",
1606+
"@kbn/shared-ux-page-analytics-no-data-mocks": "link:src/platform/packages/shared/shared-ux/page/analytics_no_data/mocks",
1607+
"@kbn/shared-ux-page-kibana-no-data-mocks": "link:src/platform/packages/shared/shared-ux/page/kibana_no_data/mocks",
16081608
"@kbn/shared-ux-page-kibana-template-mocks": "link:src/platform/packages/shared/shared-ux/page/kibana_template/mocks",
16091609
"@kbn/shared-ux-page-no-data-config-mocks": "link:src/platform/packages/shared/shared-ux/page/no_data_config/mocks",
16101610
"@kbn/shared-ux-page-no-data-mocks": "link:src/platform/packages/shared/shared-ux/page/no_data/mocks",

src/platform/packages/private/shared-ux/page/analytics_no_data/impl/README.mdx renamed to src/platform/packages/shared/shared-ux/page/analytics_no_data/impl/README.mdx

src/platform/packages/private/shared-ux/page/analytics_no_data/impl/index.ts renamed to src/platform/packages/shared/shared-ux/page/analytics_no_data/impl/index.ts

File renamed without changes.

src/platform/packages/private/shared-ux/page/analytics_no_data/impl/jest.config.js renamed to src/platform/packages/shared/shared-ux/page/analytics_no_data/impl/jest.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@
1010
module.exports = {
1111
preset: '@kbn/test',
1212
rootDir: '../../../../../../../..',
13-
roots: ['<rootDir>/src/platform/packages/private/shared-ux/page/analytics_no_data'],
13+
roots: ['<rootDir>/src/platform/packages/shared/shared-ux/page/analytics_no_data'],
1414
};

src/platform/packages/private/shared-ux/page/analytics_no_data/impl/kibana.jsonc renamed to src/platform/packages/shared/shared-ux/page/analytics_no_data/impl/kibana.jsonc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
"id": "@kbn/shared-ux-page-analytics-no-data",
44
"owner": "@elastic/appex-sharedux",
55
"group": "platform",
6-
"visibility": "private"
6+
"visibility": "shared"
77
}

src/platform/packages/private/shared-ux/page/analytics_no_data/impl/lib/get_has_api_keys.test.ts renamed to src/platform/packages/shared/shared-ux/page/analytics_no_data/impl/lib/get_has_api_keys.test.ts

File renamed without changes.

src/platform/packages/private/shared-ux/page/analytics_no_data/impl/lib/get_has_api_keys.ts renamed to src/platform/packages/shared/shared-ux/page/analytics_no_data/impl/lib/get_has_api_keys.ts

File renamed without changes.

src/platform/packages/private/shared-ux/page/analytics_no_data/impl/package.json renamed to src/platform/packages/shared/shared-ux/page/analytics_no_data/impl/package.json

File renamed without changes.

0 commit comments

Comments
 (0)