Commit bbd8413
[Automatic Import] Add date field mapping (elastic#261580)
## Summary
Fixes custom date fields being incorrectly mapped as `keyword` in
generated `fields.yml` for automatic import integrations.
The review agent produces `field_mappings` with accurate types
(including `date`), but these were discarded after the agent completed.
Instead, `generateFieldMappings` inferred types purely from JavaScript
value types in pipeline output documents — and since dates are strings
in JSON, they were always classified as `keyword`.
This PR threads the agent's `field_mappings` through to
`generateFieldMappings` so that agent-determined types (especially
`date`) are preserved in the data stream saved object and subsequently
in the built integration package's `fields.yml`.
### Changes
- **`fields.ts`**: Added an optional `agentFieldMappings` parameter to
`generateFieldMappings`. When provided, agent types override heuristic
inference for non-ECS fields. ECS types retain highest precedence.
- **`task_manager_service.ts`**: After the agent completes, extracts
`result.field_mappings` from the agent state and passes it to
`generateFieldMappings`.
### How it flows end-to-end
1. Review agent calls `submit_review` with `field_mappings` (e.g.
`[{name: "my_app.created_at", type: "date"}]`)
2. Agent state includes these in `result.field_mappings`
3. Task manager passes them to `generateFieldMappings` as type hints
4. `generateFieldMappings` uses agent types for non-ECS fields, falling
back to heuristic inference
5. Correct types are stored in the data stream saved object's
`result.field_mapping`
6. `buildIntegrationPackage` reads `field_mapping` from the saved object
and generates `fields.yml` with correct `date` types
Note: The manual pipeline edit path (`updateDataStreamPipeline`) is
unaffected — it does not have agent field mappings available, so it
continues to use heuristic inference only.
## Test plan
- [x] `fields.test.ts`: 4 new tests covering agent override, ECS
precedence, fallback, and empty array
- [x] `task_manager_service.test.ts`: 2 new tests verifying agent field
mappings are passed through (present and absent cases)
- [x] Verify end-to-end: create an integration with a data source
containing date fields, confirm `fields.yml` in the downloaded package
uses `type: date` instead of `type: keyword`
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>1 parent 941c8f2 commit bbd8413
4 files changed
Lines changed: 137 additions & 3 deletions
File tree
Lines changed: 85 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
271 | 356 | | |
272 | 357 | | |
273 | 358 | | |
| |||
Lines changed: 12 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
111 | 112 | | |
112 | 113 | | |
113 | 114 | | |
114 | | - | |
| 115 | + | |
| 116 | + | |
115 | 117 | | |
116 | 118 | | |
117 | 119 | | |
| |||
126 | 128 | | |
127 | 129 | | |
128 | 130 | | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
129 | 138 | | |
130 | 139 | | |
131 | 140 | | |
| |||
136 | 145 | | |
137 | 146 | | |
138 | 147 | | |
| 148 | + | |
139 | 149 | | |
140 | 150 | | |
141 | | - | |
| 151 | + | |
142 | 152 | | |
143 | 153 | | |
144 | 154 | | |
| |||
Lines changed: 36 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
142 | 146 | | |
143 | 147 | | |
144 | 148 | | |
| |||
178 | 182 | | |
179 | 183 | | |
180 | 184 | | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
181 | 197 | | |
182 | 198 | | |
183 | 199 | | |
| |||
885 | 901 | | |
886 | 902 | | |
887 | 903 | | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
888 | 924 | | |
889 | 925 | | |
890 | 926 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| |||
277 | 278 | | |
278 | 279 | | |
279 | 280 | | |
| 281 | + | |
280 | 282 | | |
281 | 283 | | |
282 | | - | |
| 284 | + | |
| 285 | + | |
283 | 286 | | |
284 | 287 | | |
285 | 288 | | |
| |||
0 commit comments