Skip to content

Commit c946ba8

Browse files
[Security Solution][Users page] a11y:Fix double announcement on tootips (elastic#218982)
## Summary Addresses this `a11y` issue: elastic#205327 ## Changes made: - Suppress duplicate screen-reader announcements by adding the `disableScreenReaderOutput` prop to the `EuiToolTip` wrapping the “Add filter” button. - Confirmed the `disableScreenReaderOutput` prop (introduced in EUI v101.2.0) by consulting the official tooltip documentation: https://eui.elastic.co/#/display/tooltip **How to test:** 1. Navigate to `Security -> Explore -> Users page`. 2. Navigate to `add filter` button by pressing Tab key. 3. Check the button and tooltip announcement on a screen reader. ### Sample https://github.com/user-attachments/assets/dd4528fd-9ee3-437e-953f-7fc15fdde7ac ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
1 parent 96b46b5 commit c946ba8

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/platform/plugins/shared/unified_search/public/query_string_input/add_filter_popover.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const AddFilterPopoverComponent = React.memo(function AddFilterPopover({
6565
const [showAddFilterPopover, setShowAddFilterPopover] = useState(false);
6666

6767
const button = (
68-
<EuiToolTip delay="long" content={strings.getAddFilterButtonLabel()}>
68+
<EuiToolTip delay="long" content={strings.getAddFilterButtonLabel()} disableScreenReaderOutput>
6969
<EuiButtonIcon
7070
display="base"
7171
iconType="plusInCircleFilled"

src/platform/plugins/shared/unified_search/public/query_string_input/query_bar_menu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ function QueryBarMenuComponent({
153153
};
154154

155155
const button = (
156-
<EuiToolTip delay="long" content={strings.getFilterSetButtonLabel()}>
156+
<EuiToolTip delay="long" content={strings.getFilterSetButtonLabel()} disableScreenReaderOutput>
157157
<EuiButtonIcon
158158
size="m"
159159
display="empty"

0 commit comments

Comments
 (0)