[Lens as code] Remove donut partition types (elastic#260177)

## Summary

Removes the explicit `donut` partition type. It was exactly the same as
`pie` even with the `donut_hole` property.

This way the user can define the `pie` and set the inner diameter to
make it a `donut` without changing the `type`.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

Author: nickofthyme

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/pie.test.ts

@@ -10,11 +10,11 @@
 import type { PieStateESQL, PieStateNoESQL } from './pie';
 import { pieStateSchema } from './pie';
 
-describe('Pie/Donut Schema', () => {
-  describe.each(['pie', 'donut'] as const)('%s chart type', (chartType) => {
+describe('Pie Schema', () => {
+  describe('pie chart type', () => {
     describe('Non-ES|QL Schema', () => {
       const basePieConfig = {
-        type: chartType,
+        type: 'pie',
         dataset: {
           type: 'dataView',
           id: 'test-data-view',
@@ -35,7 +35,7 @@ describe('Pie/Donut Schema', () => {
         };
 
         const validated = pieStateSchema.validate(input);
-        expect(validated.type).toBe(chartType);
+        expect(validated.type).toBe('pie');
         expect(validated.metrics).toHaveLength(1);
         expect(validated.metrics[0].operation).toBe('count');
       });
@@ -700,7 +700,7 @@ describe('Pie/Donut Schema', () => {
 
     describe('ES|QL Schema', () => {
       const baseESQLPieConfig = {
-        type: chartType,
+        type: 'pie',
         dataset: {
           type: 'esql',
           query: 'FROM my-index | STATS count() BY category',

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/pie.ts

@@ -34,7 +34,7 @@ import {
 import { groupIsNotCollapsed } from '../../utils';
 
 /**
- * Shared visualization options for pie/donut charts including legend, value display, and label positioning
+ * Shared visualization options for pie charts including legend, value display, and label positioning
  */
 const pieStateSharedSchema = {
   legend: schema.maybe(
@@ -49,7 +49,7 @@ const pieStateSharedSchema = {
         meta: {
           id: 'pieLegend',
           title: 'Legend',
-          description: 'Legend configuration for pie/donut chart',
+          description: 'Legend configuration for pie chart',
         },
       }
     )
@@ -62,15 +62,14 @@ const pieStateSharedSchema = {
         position: schema.maybe(
           schema.oneOf([schema.literal('inside'), schema.literal('outside')], {
             meta: {
-              description: 'Renders the pie/donut chart slice labels inside or outside the pie',
+              description: 'Renders pie chart slice labels inside or outside the pie',
             },
           })
         ),
       },
       {
         meta: {
-          description:
-            'Label configuration for pie/donut chart slice labels inside or outside the pie',
+          description: 'Label configuration for pie chart slice labels inside or outside the pie',
         },
       }
     )
@@ -84,7 +83,7 @@ const pieStateSharedSchema = {
 };
 
 /**
- * Color configuration for primary metric in pie/donut chart
+ * Color configuration for primary metric in pie chart
  */
 const partitionStatePrimaryMetricOptionsSchema = {
   color: schema.maybe(staticColorSchema),
@@ -98,12 +97,7 @@ const partitionStateBreakdownByOptionsSchema = {
   collapse_by: schema.maybe(collapseBySchema),
 };
 
-/**
- * Pie/donut chart type
- */
-const pieTypeSchema = schema.oneOf([schema.literal('pie'), schema.literal('donut')], {
-  meta: { description: 'Chart type: pie or donut' },
-});
+const pieTypeSchema = schema.literal('pie');
 
 function validateForMultipleMetrics({
   metrics,
@@ -126,7 +120,7 @@ function validateForMultipleMetrics({
 }
 
 /**
- * Pie/donut chart configuration for standard (non-ES|QL) queries
+ * Pie chart configuration for standard (non-ES|QL) queries
  */
 export const pieStateSchemaNoESQL = schema.object(
   {
@@ -161,15 +155,15 @@ export const pieStateSchemaNoESQL = schema.object(
   {
     meta: {
       id: 'pieNoESQL',
-      title: 'Pie/Donut Chart (DSL)',
-      description: 'Pie/donut chart configuration for standard queries',
+      title: 'Pie Chart (DSL)',
+      description: 'Pie chart configuration for standard queries',
     },
     validate: validateForMultipleMetrics,
   }
 );
 
 /**
- * Pie/donut chart configuration for ES|QL queries
+ * Pie chart configuration for ES|QL queries
  */
 export const pieStateSchemaESQL = schema.object(
   {
@@ -199,21 +193,21 @@ export const pieStateSchemaESQL = schema.object(
   {
     meta: {
       id: 'pieESQL',
-      title: 'Pie/Donut Chart (ES|QL)',
-      description: 'Pie/donut chart configuration for ES|QL queries',
+      title: 'Pie Chart (ES|QL)',
+      description: 'Pie chart configuration for ES|QL queries',
     },
     validate: validateForMultipleMetrics,
   }
 );
 
 /**
- * Complete pie/donut chart configuration supporting both standard and ES|QL queries
+ * Complete pie chart configuration supporting both standard and ES|QL queries
  */
 export const pieStateSchema = schema.oneOf([pieStateSchemaNoESQL, pieStateSchemaESQL], {
   meta: {
     id: 'pieChart',
-    title: 'Pie/Donut Chart',
-    description: 'Pie/donut chart state: standard query or ES|QL query',
+    title: 'Pie Chart',
+    description: 'Pie chart state: standard query or ES|QL query',
   },
 });
 

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/partition/lens_api_config.mock.ts

@@ -71,7 +71,7 @@ export const esqlCharts: Array<PartitionConfig> = [
     title: 'basic donut',
     sampling: 1,
     ignore_global_filters: false,
-    type: 'donut',
+    type: 'pie',
     metrics: [
       {
         operation: 'count',
@@ -330,7 +330,7 @@ export const esqlCharts: Array<PartitionConfig> = [
     title: 'donut with multiple groups',
     sampling: 1,
     ignore_global_filters: false,
-    type: 'donut',
+    type: 'pie',
     metrics: [
       {
         operation: 'count',
@@ -594,7 +594,7 @@ export const esqlCharts: Array<PartitionConfig> = [
     title: 'donut with multiple metrics',
     sampling: 1,
     ignore_global_filters: false,
-    type: 'donut',
+    type: 'pie',
     metrics: [
       {
         operation: 'count',
@@ -1049,7 +1049,7 @@ export const esqlCharts: Array<PartitionConfig> = [
     title: 'donut with color mapping',
     sampling: 1,
     ignore_global_filters: false,
-    type: 'donut',
+    type: 'pie',
     metrics: [
       {
         operation: 'count',

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/partition/partition.test.ts

@@ -36,12 +36,12 @@ import type { LensPartitionVisualizationState } from '@kbn/lens-common';
 describe('Partition', () => {
   describe('validateConverter', () => {
     const datasets = [
-      { name: 'pie/donut basic', config: pieLegacyBasicState, schema: pieStateSchema },
+      { name: 'pie basic', config: pieLegacyBasicState, schema: pieStateSchema },
       { name: 'treemap basic', config: treemapLegacyBasicState, schema: treemapStateSchema },
       { name: 'mosaic basic', config: mosaicLegacyBasicState, schema: mosaicStateSchema },
       { name: 'waffle basic', config: waffleLegacyBasicState, schema: waffleStateSchema },
       {
-        name: 'pie/donut advanced with collapsed groups',
+        name: 'pie advanced with collapsed groups',
         config: pieLegacyAdvancedStateWithMultipleMetricsAndCollapsedGroups,
         schema: pieStateSchema,
       },

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/transforms/charts/partition.ts

@@ -84,7 +84,7 @@ function isAPIPartitionLayer(layer: unknown): layer is PartitionState {
     layer !== null &&
     'type' in layer &&
     typeof layer.type === 'string' &&
-    ['pie', 'donut', 'waffle', 'treemap', 'mosaic'].includes(layer.type)
+    ['pie', 'waffle', 'treemap', 'mosaic'].includes(layer.type)
   );
 }
 
@@ -93,7 +93,7 @@ function isESQLPartitionLayer(layer: PartitionState): layer is PartitionStateESQ
 }
 
 function isAPIPieChartLayer(layer: PartitionState): layer is PieState {
-  return layer.type === 'pie' || layer.type === 'donut';
+  return layer.type === 'pie';
 }
 
 function isAPIWaffleChartLayer(layer: PartitionState): layer is WaffleState {
@@ -327,8 +327,10 @@ function buildVisualizationState(
   const isLegacyColor = isLegacyColorPalette(colorMapping);
 
   if (isAPIPieChartLayer(config)) {
+    const pieLensShape =
+      config.donut_hole != null && config.donut_hole !== 'none' ? 'donut' : 'pie';
     return {
-      shape: config.type,
+      shape: pieLensShape,
       ...(isLegacyColor && { ...colorMapping }), // legacy colors are included outside of the layer
       layers: [
         {
@@ -676,7 +678,7 @@ function convertStateCategoryDisplayOption(
 
 function fromLensStateToPerChartSpecificAPI(visualization: LensPartitionVisualizationState) {
   const vizLayer = visualization.layers[0];
-  // Pie and Donut chart have the label_position and donut_hole options
+  // Pie chart has the label_position and donut_hole options
   if (isStatePieChart(visualization)) {
     return stripUndefined({
       donut_hole: donutHoleSizeCompat.toAPI(vizLayer.emptySizeRatio),
@@ -704,7 +706,7 @@ function buildVisualizationAPI(
     ? { metric: metricsArray[0] }
     : { metrics: metricsArray };
   return stripUndefined({
-    type: visualization.shape,
+    type: isStatePieChart(visualization) ? 'pie' : visualization.shape,
     ...metricsField,
     group_by: fromLensStateToAPIGroups(visualization, layer),
     ...fromLensStateToAPISecondaryGroups(visualization, layer),