Skip to content

Commit 5d3d215

Browse files
committed
Put back variable to define patch value.
Fix python builds. Signed-off-by: Peter Targett <[email protected]>
1 parent 1847f6f commit 5d3d215

File tree

7 files changed

+26
-12
lines changed

7 files changed

+26
-12
lines changed

CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ cmake_minimum_required(VERSION 3.18.2)
88

99
set(OTIO_VERSION_MAJOR "0")
1010
set(OTIO_VERSION_MINOR "18")
11-
set(OTIO_VERSION ${OTIO_VERSION_MAJOR}.${OTIO_VERSION_MINOR}.0)
11+
set(OTIO_VERSION_PATCH "0")
12+
set(OTIO_VERSION ${OTIO_VERSION_MAJOR}.${OTIO_VERSION_MINOR}.${OTIO_VERSION_PATCH})
1213

1314
set(OTIO_AUTHOR "Contributors to the OpenTimelineIO project")
1415
set(OTIO_AUTHOR_EMAIL "[email protected]")

src/opentime/CMakeLists.txt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@ target_compile_options(opentime PRIVATE
4747
$<$<CXX_COMPILER_ID:MSVC>: /EHsc>
4848
)
4949

50+
configure_file(
51+
${CMAKE_CURRENT_SOURCE_DIR}/version.h.in
52+
${CMAKE_CURRENT_BINARY_DIR}/version.h
53+
)
54+
5055
if(OTIO_CXX_INSTALL)
5156
install(FILES ${OPENTIME_HEADER_FILES}
5257
DESTINATION "${OTIO_RESOLVED_CXX_INSTALL_DIR}/include/opentime")
@@ -78,10 +83,7 @@ if(OTIO_CXX_INSTALL)
7883
DESTINATION
7984
${OTIO_RESOLVED_CXX_INSTALL_DIR}/share/opentime
8085
)
81-
configure_file(
82-
${CMAKE_CURRENT_SOURCE_DIR}/version.h.in
83-
${CMAKE_CURRENT_BINARY_DIR}/version.h
84-
)
86+
8587
install(
8688
FILES
8789
${CMAKE_CURRENT_BINARY_DIR}/version.h

src/opentime/version.h.in

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33

44
#pragma once
55

6-
#define OPENTIME_VERSION v@PROJECT_VERSION_MAJOR@_@OpenTimelineIO_VERSION_MINOR@
6+
#define OPENTIME_VERSION_MAJOR @PROJECT_VERSION_MAJOR@
7+
#define OPENTIME_VERSION_MINOR @PROJECT_VERSION_MINOR@
8+
#define OPENTIME_VERSION_PATCH @PROJECT_VERSION_PATCH@
9+
#define OPENTIME_VERSION v@PROJECT_VERSION_MAJOR@_@PROJECT_VERSION_MINOR@_@PROJECT_VERSION_PATCH@
710

811
namespace opentime {
912
namespace OPENTIME_VERSION {

src/opentimelineio/CMakeLists.txt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,11 @@ target_compile_options(opentimelineio PRIVATE
121121
$<$<CXX_COMPILER_ID:MSVC>: /EHsc>
122122
)
123123

124+
configure_file(
125+
${CMAKE_CURRENT_SOURCE_DIR}/version.h.in
126+
${CMAKE_CURRENT_BINARY_DIR}/version.h
127+
)
128+
124129
if(OTIO_CXX_INSTALL)
125130
install(FILES ${OPENTIMELINEIO_HEADER_FILES}
126131
DESTINATION "${OTIO_RESOLVED_CXX_INSTALL_DIR}/include/opentimelineio")
@@ -154,10 +159,7 @@ if(OTIO_CXX_INSTALL)
154159
DESTINATION
155160
${OTIO_RESOLVED_CXX_INSTALL_DIR}/share/opentimelineio
156161
)
157-
configure_file(
158-
${CMAKE_CURRENT_SOURCE_DIR}/version.h.in
159-
${CMAKE_CURRENT_BINARY_DIR}/version.h
160-
)
162+
161163
install(
162164
FILES
163165
${CMAKE_CURRENT_BINARY_DIR}/version.h

src/opentimelineio/version.h.in

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33

44
#pragma once
55

6-
#define OPENTIMELINEIO_VERSION v@PROJECT_VERSION_MAJOR@_@OpenTimelineIO_VERSION_MINOR@
6+
#define OPENTIMELINEIO_VERSION_MAJOR @PROJECT_VERSION_MAJOR@
7+
#define OPENTIMELINEIO_VERSION_MINOR @PROJECT_VERSION_MINOR@
8+
#define OPENTIMELINEIO_VERSION_PATCH @PROJECT_VERSION_PATCH@
9+
#define OPENTIMELINEIO_VERSION v@PROJECT_VERSION_MAJOR@_@PROJECT_VERSION_MINOR@_@PROJECT_VERSION_PATCH@
710

811
#include "opentime/rationalTime.h"
912
#include "opentime/timeRange.h"

src/py-opentimelineio/opentime-bindings/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ target_include_directories(_opentime
1212
PRIVATE pybind11/include
1313
PRIVATE "${PROJECT_SOURCE_DIR}/src"
1414
PRIVATE "${PROJECT_SOURCE_DIR}/src/deps"
15-
PRIVATE "${PROJECT_SOURCE_DIR}/src/deps/optional-lite/include")
15+
PRIVATE "${PROJECT_SOURCE_DIR}/src/deps/optional-lite/include"
16+
PRIVATE "${CMAKE_BINARY_DIR}/src"
17+
)
1618

1719
target_link_libraries(_opentime PUBLIC opentimelineio opentime)
1820

src/py-opentimelineio/opentimelineio-bindings/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ target_include_directories(_otio
2323
PRIVATE "${PROJECT_SOURCE_DIR}/src"
2424
PRIVATE "${PROJECT_SOURCE_DIR}/src/deps"
2525
PRIVATE "${PROJECT_SOURCE_DIR}/src/deps/optional-lite/include"
26+
PRIVATE "${CMAKE_BINARY_DIR}/src"
2627
)
2728

2829
target_link_libraries(_otio PUBLIC opentimelineio opentime)

0 commit comments

Comments
 (0)