link: add option to suppress printing of ACKs from other systems

Author: peterbarker

Diff for: MAVProxy/mavproxy.py

@@ -289,6 +289,8 @@ def __init__(self):
 
               MPSetting('vehicle_name', str, '', 'Vehicle Name', tab='Vehicle'),
 
+              MPSetting('all_vehicle_command_acks', bool, True, 'Show COMMAND_ACKs even if they are targetted at other vehicles'),
+
               MPSetting('sys_status_error_warn_interval', int, 30, 'interval to warn of autopilot software failure'),
 
               MPSetting('inhibit_screensaver_when_armed', bool, False, 'inhibit screensaver while vehicle armed'),

Diff for: MAVProxy/modules/mavproxy_link.py

@@ -613,6 +613,37 @@ def heartbeat_is_from_autopilot(self, m):
 
         return True
 
+    def should_show_command_ack(self, m):
+        '''returns true if we should display some text on the console for m'''
+        if m.target_component in [mavutil.mavlink.MAV_COMP_ID_MAVCAN]:
+            # too noisy?
+            return False
+
+        if m.command in frozenset([
+                mavutil.mavlink.MAV_CMD_GET_HOME_POSITION,
+                mavutil.mavlink.MAV_CMD_DO_DIGICAM_CONTROL
+        ]):
+            # too noisy?
+            return False
+
+        if self.settings.all_vehicle_command_acks:
+            # we're showing everything
+            return True
+
+        if m.target_system == 0:
+            return True
+
+        if m.target_system != self.settings.source_system:
+            return False
+
+        if m.target_component == 0:
+            return True
+
+        if m.target_component != self.settings.source_component:
+            return False
+
+        return True
+
     def master_msg_handling(self, m, master):
         '''link message handling for an upstream link'''
         if not self.message_is_from_primary_vehicle(m):
@@ -827,11 +858,9 @@ def accumulated_statustext(self):
                 cmd = cmd[8:]
                 res = mavutil.mavlink.enums["MAV_RESULT"][m.result].name
                 res = res[11:]
-                if (m.target_component not in [mavutil.mavlink.MAV_COMP_ID_MAVCAN] and
-                    m.command not in [mavutil.mavlink.MAV_CMD_GET_HOME_POSITION,
-                                      mavutil.mavlink.MAV_CMD_DO_DIGICAM_CONTROL]):
+                if self.should_show_command_ack(m):
                     self.mpstate.console.writeln("Got COMMAND_ACK: %s: %s" % (cmd, res))
-            except Exception:
+            except KeyError as e:
                 self.mpstate.console.writeln("Got MAVLink msg: %s" % m)
 
             if m.command == mavutil.mavlink.MAV_CMD_PREFLIGHT_CALIBRATION: