You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/plans/encoding.md
+19-3Lines changed: 19 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -86,9 +86,25 @@
86
86
87
87
#### Phase 6: Quality assurance
88
88
89
-
-[ ] Run pre-push script
90
-
-[ ] Verify all tests pass
91
-
-[ ] Update plan as complete
89
+
-[x] Run pre-push script
90
+
-[x] Verify all tests pass
91
+
-[x] Update plan as complete
92
+
93
+
**Implementation Notes:**
94
+
- Pre-push script passed: linting, formatting, type checking, all 55 tests
95
+
-**76% test coverage** maintained throughout implementation
96
+
-**ASCII detection fix** resolved integration test failures
97
+
- All encoding auto-detection working correctly across the codebase
98
+
99
+
## Implementation Complete
100
+
101
+
**Summary**: Successfully replaced encoding parameters with chardet auto-detection across all 4 MCP tools and internal functions. API simplified, reliability improved, all tests passing.
102
+
103
+
**Key Changes**:
104
+
- Added `detect_file_encoding()` with 0.7 confidence threshold and ASCII→UTF-8 conversion
105
+
- Removed encoding parameters from 15+ functions across 4 files
106
+
- Updated MCP schemas, documentation, and examples
107
+
- Maintained backward compatibility through graceful fallbacks
0 commit comments