Skip to content

Commit 9c571cb

Browse files
Merge pull request #6 from BubbleTrouble14/main
Fix android failing to build when using with expo 50
2 parents 4d22b2e + 6a504c7 commit 9c571cb

3 files changed

Lines changed: 2314 additions & 820 deletions

File tree

android/build.gradle

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,16 @@ android {
5858
targetCompatibility JavaVersion.VERSION_11
5959
}
6060

61-
kotlinOptions {
62-
jvmTarget = JavaVersion.VERSION_11.majorVersion
61+
def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
62+
if (agpVersion.tokenize('.')[0].toInteger() < 8) {
63+
compileOptions {
64+
sourceCompatibility JavaVersion.VERSION_11
65+
targetCompatibility JavaVersion.VERSION_11
66+
}
67+
68+
kotlinOptions {
69+
jvmTarget = JavaVersion.VERSION_11.majorVersion
70+
}
6371
}
6472

6573
namespace "expo.modules.passkeys"

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
"@changesets/cli": "^2.26.2",
3636
"@simplewebauthn/typescript-types": "^8.0.0",
3737
"@types/react": "^18.0.25",
38-
"expo-module-scripts": "^3.0.11",
39-
"expo-modules-core": "^1.5.7",
38+
"expo-module-scripts": "^3.4.1",
39+
"expo-modules-core": "^1.11.9",
4040
"typescript": "^5.2.2"
4141
},
4242
"peerDependencies": {

0 commit comments

Comments
 (0)