fix(discord): replace dead client ID, make it configurable (#88)

The bundled Rich Presence application ID was rejected by Discord (404 /
InvalidID 4000), so RPC never connected. Swap in a freshly registered
app ID and expose it as [discord] client_id so users can point at their
own application — and so a future ID rotation is a config change, not a
code release.

The bundled ID lives in one place (DEFAULT_DISCORD_CLIENT_ID); an empty
config value falls back to it. Verified live: connects to a running
client and publishes the activity.

Author: peternaame-boop

docs/configuration.md

@@ -107,6 +107,8 @@ enabled = true
 ```toml
 [discord]
 enabled = false              # requires `pip install ytm-player[discord]`
+client_id = ""               # blank uses the bundled app; set your own
+                             # Discord application ID to publish under it
 ```
 
 ### `[lastfm]`

src/ytm_player/app/_app.py

@@ -608,7 +608,7 @@ async def on_mount(self) -> None:
 
         # Start Discord Rich Presence if enabled.
         if self.settings.discord.enabled:
-            self.discord = DiscordRPC()
+            self.discord = DiscordRPC(client_id=self.settings.discord.client_id)
             await self.discord.connect()
 
         # Start Last.fm scrobbling if enabled.

src/ytm_player/config/settings.py

@@ -102,6 +102,9 @@ class MPRISSettings:
 @dataclass
 class DiscordSettings:
     enabled: bool = False
+    # Empty = use the bundled "YouTube Music" app; set to your own Discord
+    # application ID to publish Rich Presence under your own app.
+    client_id: str = ""
 
 
 @dataclass

src/ytm_player/services/discord_rpc.py

@@ -11,8 +11,9 @@
 
 logger = logging.getLogger(__name__)
 
-# Discord application ID for ytm-player (YouTube Music category).
-_CLIENT_ID = "1338519089781362698"
+# Default Discord application ID — the bundled "YouTube Music" Rich Presence
+# app. Users can point at their own app via [discord] client_id in config.
+DEFAULT_DISCORD_CLIENT_ID = "1517429270115258490"
 
 
 class DiscordRPC:
@@ -22,7 +23,10 @@ class DiscordRPC:
     Reconnects automatically if the connection drops.
     """
 
-    def __init__(self) -> None:
+    def __init__(self, client_id: str = "") -> None:
+        # Blank/whitespace falls back to the bundled app, so an empty config
+        # value doesn't break RPC; `enabled = false` is the real off switch.
+        self._client_id = client_id.strip() or DEFAULT_DISCORD_CLIENT_ID
         self._rpc: object | None = None
         self._connected = False
         self._start_time: float = 0
@@ -38,7 +42,7 @@ async def connect(self) -> bool:
             return False
 
         try:
-            self._rpc = AioPresence(_CLIENT_ID)
+            self._rpc = AioPresence(self._client_id)
             await self._rpc.connect()  # type: ignore[union-attr]
             self._connected = True
             logger.info("Connected to Discord Rich Presence")

tests/test_config/test_settings_extended.py

@@ -36,6 +36,7 @@ class TestPhase2Fields:
     def test_discord_defaults(self):
         d = DiscordSettings()
         assert d.enabled is False
+        assert d.client_id == ""
 
     def test_lastfm_defaults(self):
         lf = LastFMSettings()
@@ -65,10 +66,12 @@ def test_discord_round_trip(self, tmp_config_dir):
         path = tmp_config_dir / "config.toml"
         s = Settings()
         s.discord.enabled = True
+        s.discord.client_id = "1234567890"
         s.save(path)
 
         loaded = Settings.load(path)
         assert loaded.discord.enabled is True
+        assert loaded.discord.client_id == "1234567890"
 
 
 class TestLyricsSettings:

tests/test_services/test_discord_rpc.py

@@ -1,6 +1,6 @@
 """Tests for DiscordRPC (no external dependencies needed)."""
 
-from ytm_player.services.discord_rpc import DiscordRPC
+from ytm_player.services.discord_rpc import DEFAULT_DISCORD_CLIENT_ID, DiscordRPC
 
 
 class TestDiscordRPCInit:
@@ -9,3 +9,17 @@ def test_initial_state(self):
         assert rpc.is_connected is False
         assert rpc._rpc is None
         assert rpc._start_time == 0
+
+    def test_default_client_id(self):
+        """No client_id given → uses the bundled default."""
+        assert DiscordRPC()._client_id == DEFAULT_DISCORD_CLIENT_ID
+
+    def test_custom_client_id(self):
+        """A user-supplied client_id is honoured (and trimmed)."""
+        assert DiscordRPC(client_id="998877665544332211")._client_id == "998877665544332211"
+        assert DiscordRPC(client_id="  998877665544332211  ")._client_id == "998877665544332211"
+
+    def test_empty_client_id_falls_back(self):
+        """Empty or whitespace-only client_id falls back to the default (#88)."""
+        assert DiscordRPC(client_id="")._client_id == DEFAULT_DISCORD_CLIENT_ID
+        assert DiscordRPC(client_id="   ")._client_id == DEFAULT_DISCORD_CLIENT_ID