Using setup.sh on POSIX compliant Unix systems (e.g. macOS)

[paul-jarrow]

It looks like a few of the shell commands in the setup script won't run correctly on macOS.

I've found that I can solve this by modifying the script slightly:

setup.sh:

sed -i .orig 's/GIT_PACK_FILE_MODE 0444/GIT_PACK_FILE_MODE 0644/g' libgit2/src/libgit2/pack.h
sed -i .orig 's/GIT_OBJECT_FILE_MODE 0444/GIT_OBJECT_FILE_MODE 0644/g' libgit2/src/libgit2/odb.h

Adding the designation .orig after the -i flag seems to do the trick.

[eliot-akira]

This is a compatiblity issue with macOS shipping the FreeBSD version of sed, which has many slightly different options than the more standard sed on Linux.

• Differences between sed on Mac OSX and other "standard" sed

I think your macOS-specific solution is related to this:

-i works with GNU sed, recent versions of NetBSD, OpenBSD sed, but not OS X's sed. -i -e works with both but in the case of FreeBSD sed makes a backup of the original file with -e appended to the file name.

In the OS X version -i always requires a suffix, even if an empty string. so -i '' -e should work.

So this extra option can be applied for that platform only. An empty string is better in this case, for the commands to have the same behavior as on Linux.